From: gaurav jindal <gauravjindal1104@gmail.com>
To: rjw@rjwysocki.net, daniel.lezcano@linaro.org
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
toddpoynor@google.com
Subject: [PATCH] drivers: cpuidle: Fix checkpatch error and warnings
Date: Thu, 7 Sep 2017 15:53:25 +0530 [thread overview]
Message-ID: <20170907102325.GA6427@kernel> (raw)
This patch fixes the below checkpatch errors and warnings in
drivers/cpuidle/cpuidle.c
WARNING: line over 80 characters
#311: FILE: drivers/cpuidle/cpuidle.c:311:
+ /* Make sure all changes finished before we switch to new idle */
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#343: FILE: drivers/cpuidle/cpuidle.c:343:
+EXPORT_SYMBOL_GPL(cpuidle_pause_and_lock);
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#354: FILE: drivers/cpuidle/cpuidle.c:354:
+EXPORT_SYMBOL_GPL(cpuidle_resume_and_unlock);
ERROR: do not use assignment in if condition
#402: FILE: drivers/cpuidle/cpuidle.c:402:
+ if (cpuidle_curr_governor->enable &&
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#419: FILE: drivers/cpuidle/cpuidle.c:419:
+EXPORT_SYMBOL_GPL(cpuidle_enable_device);
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#447: FILE: drivers/cpuidle/cpuidle.c:447:
+EXPORT_SYMBOL_GPL(cpuidle_disable_device);
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#537: FILE: drivers/cpuidle/cpuidle.c:537:
+EXPORT_SYMBOL_GPL(cpuidle_register_device);
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#561: FILE: drivers/cpuidle/cpuidle.c:561:
+EXPORT_SYMBOL_GPL(cpuidle_unregister_device);
Signed-off-by: gaurav jindal<gauravjindal1104@gmail.com>
---
diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
index 60bb64f..a42148e 100644
--- a/drivers/cpuidle/cpuidle.c
+++ b/drivers/cpuidle/cpuidle.c
@@ -308,7 +308,10 @@ void cpuidle_reflect(struct cpuidle_device *dev, int index)
void cpuidle_install_idle_handler(void)
{
if (enabled_devices) {
- /* Make sure all changes finished before we switch to new idle */
+ /*
+ * Make sure all changes finished before we switch to
+ * new idle
+ */
smp_wmb();
initialized = 1;
}
@@ -339,7 +342,6 @@ void cpuidle_pause_and_lock(void)
mutex_lock(&cpuidle_lock);
cpuidle_uninstall_idle_handler();
}
-
EXPORT_SYMBOL_GPL(cpuidle_pause_and_lock);
/**
@@ -350,7 +352,6 @@ void cpuidle_resume_and_unlock(void)
cpuidle_install_idle_handler();
mutex_unlock(&cpuidle_lock);
}
-
EXPORT_SYMBOL_GPL(cpuidle_resume_and_unlock);
/* Currently used in suspend/resume path to suspend cpuidle */
@@ -399,9 +400,12 @@ int cpuidle_enable_device(struct cpuidle_device *dev)
if (ret)
return ret;
- if (cpuidle_curr_governor->enable &&
- (ret = cpuidle_curr_governor->enable(drv, dev)))
- goto fail_sysfs;
+ if (cpuidle_curr_governor->enable) {
+
+ ret = cpuidle_curr_governor->enable(drv, dev);
+ if (ret)
+ goto fail_sysfs;
+ }
smp_wmb();
@@ -415,7 +419,6 @@ int cpuidle_enable_device(struct cpuidle_device *dev)
return ret;
}
-
EXPORT_SYMBOL_GPL(cpuidle_enable_device);
/**
@@ -443,7 +446,6 @@ void cpuidle_disable_device(struct cpuidle_device *dev)
cpuidle_remove_device_sysfs(dev);
enabled_devices--;
}
-
EXPORT_SYMBOL_GPL(cpuidle_disable_device);
static void __cpuidle_unregister_device(struct cpuidle_device *dev)
@@ -533,7 +535,6 @@ int cpuidle_register_device(struct cpuidle_device *dev)
__cpuidle_unregister_device(dev);
goto out_unlock;
}
-
EXPORT_SYMBOL_GPL(cpuidle_register_device);
/**
@@ -557,7 +558,6 @@ void cpuidle_unregister_device(struct cpuidle_device *dev)
cpuidle_resume_and_unlock();
}
-
EXPORT_SYMBOL_GPL(cpuidle_unregister_device);
/**
next reply other threads:[~2017-09-07 10:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-07 10:23 gaurav jindal [this message]
2017-09-07 10:33 ` [PATCH] drivers: cpuidle: Fix checkpatch error and warnings Joe Perches
2017-09-07 12:40 ` gaurav jindal
2017-09-07 23:18 ` Rafael J. Wysocki
2017-09-08 13:36 ` gaurav jindal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170907102325.GA6427@kernel \
--to=gauravjindal1104@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=toddpoynor@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.