From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Daniel Stone <daniel@fooishbar.org>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>,
Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH 2/2] drm/i915: Fail addfb ioctl if color and CCS buffers overlap
Date: Thu, 7 Sep 2017 15:19:14 +0300 [thread overview]
Message-ID: <20170907121914.GA4914@intel.com> (raw)
In-Reply-To: <CAPj87rOagq=J5qshshxP6CBAPOww+zpP+3ak6uRrWXy_jVKX6w@mail.gmail.com>
On Tue, Sep 05, 2017 at 08:36:54AM +0100, Daniel Stone wrote:
> Hi Ville,
>
> On 4 September 2017 at 17:37, Ville Syrjälä
> <ville.syrjala@linux.intel.com> wrote:
> > On Thu, Aug 31, 2017 at 04:52:15PM -0300, Gabriel Krisman Bertazi wrote:
> >> With this patch the new testcase igt@kms_ccs@pipe-X-invalid-ccs-offset
> >> succeeds.
> >
> > I don't think we actually want to reject overlap. I had a patch for that
> > years ago, but I decided to drop it because people might want to
> > interleave the planes in some interesting ways. Making the overlap
> > check accurate enough to allow that would be to total overkill. So IMO
> > it's perfectly fine to let the user shoot himself in the foot if they
> > mess up the offsets.
>
> Is that actually supported by any hardware renderer? If not, maybe the
> check should only be enabled for generations who support it.
Not sure I understand the question. You can program your offsets/strides
any which way you want,
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-09-07 12:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-31 19:52 [PATCH 1/2] drm: Fix example comment of format modifier blob Gabriel Krisman Bertazi
2017-08-31 19:52 ` [PATCH 2/2] drm/i915: Fail addfb ioctl if color and CCS buffers overlap Gabriel Krisman Bertazi
2017-08-31 20:06 ` Ben Widawsky
2017-09-01 4:35 ` Gabriel Krisman Bertazi
2017-09-04 8:21 ` Daniel Vetter
2017-09-04 16:37 ` Ville Syrjälä
2017-09-05 7:36 ` Daniel Stone
2017-09-07 12:19 ` Ville Syrjälä [this message]
2017-09-22 5:25 ` Gabriel Krisman Bertazi
2017-09-22 11:54 ` Ville Syrjälä
2017-08-31 20:00 ` [PATCH 1/2] drm: Fix example comment of format modifier blob Ben Widawsky
2017-09-04 8:24 ` Daniel Vetter
2017-08-31 20:22 ` ✓ Fi.CI.BAT: success for series starting with [1/2] " Patchwork
2017-08-31 23:37 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170907121914.GA4914@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=ben@bwidawsk.net \
--cc=daniel@fooishbar.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.