From: Kalle Valo <kvalo@codeaurora.org>
To: Eric Bentley <eric.bentley@lairdtech.com>
Cc: Steve deRosier <derosier@gmail.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"arend.vanspriel@broadcom.com" <arend.vanspriel@broadcom.com>
Subject: Re: [v2] brcmfmac: Correctly fail to suspend when SDIO does not support power on suspend
Date: Thu, 7 Sep 2017 12:54:51 +0000 (UTC) [thread overview]
Message-ID: <20170907125451.AE5A66072F@smtp.codeaurora.org> (raw)
In-Reply-To: <AC37C967-209B-4BC3-9AF2-9CC4C27391C0@lairdtech.com>
Eric Bentley <eric.bentley@lairdtech.com> wrote:
> Return error when failing to set power management capabilities flag. This will
> cause the suspend to fail but the radio will continue to operate. Allowing this
> to fail without reporting error will cause the radio to be non-functional on
> resume as it will have lost power.
>
> Signed-off-by: Eric Bentley eric.bentley@lairdtech.com
The patch is corrupted. It seems you used outlook to submit it which is
a recipe for a disaster:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#format_issues
Also please improve the commit log like Arend mentioned.
fatal: corrupt patch at line 23
error: could not build fake ancestor
Applying: brcmfmac: Correctly fail to suspend when SDIO does not support power on suspend
Patch failed at 0001 brcmfmac: Correctly fail to suspend when SDIO does not support power on suspend
The copy of the patch that failed is found in: .git/rebase-apply/patch
Patch set to Changes Requested.
--
https://patchwork.kernel.org/patch/9934065/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2017-09-07 12:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-01 13:00 [PATCH v2] brcmfmac: Correctly fail to suspend when SDIO does not support power on suspend Eric Bentley
2017-09-01 20:02 ` Arend van Spriel
2017-09-04 19:33 ` Steve deRosier
2017-09-04 20:40 ` Arend van Spriel
2017-09-07 12:54 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170907125451.AE5A66072F@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=arend.vanspriel@broadcom.com \
--cc=derosier@gmail.com \
--cc=eric.bentley@lairdtech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.