From: Andrew Lunn <andrew@lunn.ch>
To: Nisar.Sayed@microchip.com
Cc: davem@davemloft.net, UNGLinuxDriver@microchip.com,
netdev@vger.kernel.org, steve.glendinning@shawell.net
Subject: Re: [PATCH net] smsc95xx: Configure pause time to 0xffff when tx flow control enabled
Date: Thu, 7 Sep 2017 15:56:58 +0200 [thread overview]
Message-ID: <20170907135658.GG11248@lunn.ch> (raw)
In-Reply-To: <CE371C1263339941885964188A0225FA3339DB@CHN-SV-EXMX03.mchp-main.com>
On Thu, Sep 07, 2017 at 06:51:37AM +0000, Nisar.Sayed@microchip.com wrote:
> From: Nisar Sayed <Nisar.Sayed@microchip.com>
>
> Configure pause time to 0xffff when tx flow control enabled
Hi Nisar
You should explain the 'Why' in the commit message. Why do we want a
pause time of 0xffff?
Andrew
next prev parent reply other threads:[~2017-09-07 13:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-07 6:51 [PATCH net] smsc95xx: Configure pause time to 0xffff when tx flow control enabled Nisar.Sayed
2017-09-07 13:56 ` Andrew Lunn [this message]
2017-09-08 9:11 ` Nisar.Sayed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170907135658.GG11248@lunn.ch \
--to=andrew@lunn.ch \
--cc=Nisar.Sayed@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=steve.glendinning@shawell.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.