From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Colin Ian King <colin.king@canonical.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Linux-Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the tpmdd tree
Date: Thu, 7 Sep 2017 19:21:01 +0300 [thread overview]
Message-ID: <20170907162101.rxacve5xsnvan3qs@linux.intel.com> (raw)
In-Reply-To: <a14159a4-5bb6-ce63-3dcb-985b4247adf6@canonical.com>
Colin, Stephen,
Thank you. I'll apply Colin's fix.
/Jarkko
On Thu, Sep 07, 2017 at 09:43:37AM +0100, Colin Ian King wrote:
> Thanks for reporting that Stephen, I've sent a fix to address this issue.
>
> Colin
>
> On 07/09/17 03:31, Stephen Rothwell wrote:
> > Hi Jarkko,
> >
> > After merging the tpmdd tree, today's linux-next build (x86_64
> > allmodconfig) produced this warning:
> >
> > drivers/char/tpm/tpm_tis_core.c: In function 'probe_itpm':
> > drivers/char/tpm/tpm_tis_core.c:469:31: warning: passing argument 2 of 'tpm_tis_send_data' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
> > rc = tpm_tis_send_data(chip, cmd_getticks, len);
> > ^
> > drivers/char/tpm/tpm_tis_core.c:255:12: note: expected 'u8 * {aka unsigned char *}' but argument is of type 'const u8 * {aka const unsigned char *}'
> > static int tpm_tis_send_data(struct tpm_chip *chip, u8 *buf, size_t len)
> > ^
> > drivers/char/tpm/tpm_tis_core.c:477:31: warning: passing argument 2 of 'tpm_tis_send_data' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
> > rc = tpm_tis_send_data(chip, cmd_getticks, len);
> > ^
> > drivers/char/tpm/tpm_tis_core.c:255:12: note: expected 'u8 * {aka unsigned char *}' but argument is of type 'const u8 * {aka const unsigned char *}'
> > static int tpm_tis_send_data(struct tpm_chip *chip, u8 *buf, size_t len)
> > ^
> >
> > Introduced by commit
> >
> > 5e35bd8e06b9 ("tpm_tis: make array cmd_getticks static const to shink object code size")
> >
>
next prev parent reply other threads:[~2017-09-07 16:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-07 2:31 linux-next: build warning after merge of the tpmdd tree Stephen Rothwell
2017-09-07 8:43 ` Colin Ian King
2017-09-07 16:21 ` Jarkko Sakkinen [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-03-11 10:00 Stephen Rothwell
2025-03-11 10:10 ` Jarkko Sakkinen
2025-03-11 14:21 ` Stuart Yoder
2025-03-12 6:16 ` Jarkko Sakkinen
2024-05-06 6:21 Stephen Rothwell
2024-05-06 10:48 ` Bagas Sanjaya
2024-05-06 10:55 ` Bagas Sanjaya
2019-06-11 4:52 Stephen Rothwell
2019-06-13 15:13 ` Jarkko Sakkinen
2019-02-07 2:47 Stephen Rothwell
2019-02-07 21:16 ` Jarkko Sakkinen
2018-01-02 2:50 Stephen Rothwell
2018-01-02 4:05 ` Shaikh, Azhar
2016-11-15 1:01 Stephen Rothwell
2016-11-15 2:13 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170907162101.rxacve5xsnvan3qs@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=colin.king@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.