All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915: Apply the GTT write flush for all !llc machines
@ 2017-09-07 14:31 Chris Wilson
  2017-09-07 14:48 ` ✗ Fi.CI.BAT: warning for " Patchwork
                   ` (3 more replies)
  0 siblings, 4 replies; 9+ messages in thread
From: Chris Wilson @ 2017-09-07 14:31 UTC (permalink / raw)
  To: intel-gfx

We also see the delayed GTT write issue on i915g/i915gm, so let's
presume that it is a universal problem for all llc machines, and that we
just haven't yet noticed on g33, gen4 and gen5 machines.

Testcase: igt/gem_mmap_gtt/coherency # i915gm
References: https://bugs.freedesktop.org/show_bug.cgi?id=102577
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/i915_gem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 4dffebae5601..350b761b9e91 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -694,7 +694,7 @@ flush_write_domain(struct drm_i915_gem_object *obj, unsigned int flush_domains)
 
 	switch (obj->base.write_domain) {
 	case I915_GEM_DOMAIN_GTT:
-		if (INTEL_GEN(dev_priv) >= 6 && !HAS_LLC(dev_priv)) {
+		if (!HAS_LLC(dev_priv)) {
 			intel_runtime_pm_get(dev_priv);
 			spin_lock_irq(&dev_priv->uncore.lock);
 			POSTING_READ_FW(RING_ACTHD(dev_priv->engine[RCS]->mmio_base));
-- 
2.14.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2017-09-07 20:46 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-07 14:31 [PATCH] drm/i915: Apply the GTT write flush for all !llc machines Chris Wilson
2017-09-07 14:48 ` ✗ Fi.CI.BAT: warning for " Patchwork
2017-09-07 18:23 ` [PATCH] " Ville Syrjälä
2017-09-07 18:35   ` Chris Wilson
2017-09-07 18:47     ` Ville Syrjälä
2017-09-07 18:45 ` [PATCH v2] " Chris Wilson
2017-09-07 18:50   ` Ville Syrjälä
2017-09-07 20:46     ` Chris Wilson
2017-09-07 19:07 ` ✗ Fi.CI.BAT: failure for drm/i915: Apply the GTT write flush for all !llc machines (rev2) Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.