From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ross Zwisler Subject: Re: [PATCH 0/9] add ext4 per-inode DAX flag Date: Thu, 7 Sep 2017 15:13:03 -0600 Message-ID: <20170907211303.GA23212@linux.intel.com> References: <20170905223541.20594-1-ross.zwisler@linux.intel.com> <20170906170754.GB17663@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Eric Sandeen , Theodore Ts'o , "Darrick J. Wong" , Jan Kara , "linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org" , Dave Chinner , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Christoph Hellwig , linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Andreas Dilger , Lukas Czerner , linux-ext4 , Andrew Morton To: Dan Williams Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" List-Id: linux-ext4.vger.kernel.org On Thu, Sep 07, 2017 at 01:54:45PM -0700, Dan Williams wrote: > On Wed, Sep 6, 2017 at 10:07 AM, Ross Zwisler > wrote: > > On Tue, Sep 05, 2017 at 09:12:35PM -0500, Eric Sandeen wrote: > >> On 9/5/17 5:35 PM, Ross Zwisler wrote: > >> > The original intent of this series was to add a per-inode DAX flag to ext4 > >> > so that it would be consistent with XFS. In my travels I found and fixed > >> > several related issues in both ext4 and XFS. > >> > >> Hi Ross - > >> > >> hch had a lot of reasons to nuke the dax flag from orbit, and we just > >> /disabled/ it in xfs due to its habit of crashing the kernel... > > > > Ah, sorry, I wasn't CC'd on those threads and missed them. For any interested > > bystanders: > > > > https://www.spinics.net/lists/linux-ext4/msg57840.html > > https://www.spinics.net/lists/linux-xfs/msg09831.html > > https://www.spinics.net/lists/linux-xfs/msg10124.html > > > >> so a couple questions: > >> > >> 1) does this series pass hch's "test the per-inode DAX flag" fstest? > > > > Nope, it has the exact same problems as the XFS per-inode DAX flag. > > > >> 2) do we have an agreement that we need this flag at all, or is this > >> just a parity item because xfs has^whad a per-inode flag? > > > > It was for parity, and because it allows admins finer grained control over > > their system. Basically all things discussed in response to Lukas's original > > patch in the first link above. > > I think it's more than parity. When pmem is slower than page cache it > is actively harmful to have DAX enabled globally for a filesystem. So, > not only should we push for per-inode DAX control, we should also push > to deprecate the mount option. I agree with Christoph that we should > try to automatically and transparently enable DAX where it makes > sense, but we also need a finer-grained mechanism than a mount flag to > force the behavior one way or the other. Yep, agreed. I'll play with how to make this work after I've sorted out all the data corruptions I've found. :) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8776020945612 for ; Thu, 7 Sep 2017 14:10:22 -0700 (PDT) Date: Thu, 7 Sep 2017 15:13:03 -0600 From: Ross Zwisler Subject: Re: [PATCH 0/9] add ext4 per-inode DAX flag Message-ID: <20170907211303.GA23212@linux.intel.com> References: <20170905223541.20594-1-ross.zwisler@linux.intel.com> <20170906170754.GB17663@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Dan Williams Cc: Eric Sandeen , Theodore Ts'o , "Darrick J. Wong" , Jan Kara , "linux-nvdimm@lists.01.org" , Dave Chinner , "linux-kernel@vger.kernel.org" , Christoph Hellwig , linux-xfs@vger.kernel.org, Andreas Dilger , Lukas Czerner , linux-ext4 , Andrew Morton List-ID: On Thu, Sep 07, 2017 at 01:54:45PM -0700, Dan Williams wrote: > On Wed, Sep 6, 2017 at 10:07 AM, Ross Zwisler > wrote: > > On Tue, Sep 05, 2017 at 09:12:35PM -0500, Eric Sandeen wrote: > >> On 9/5/17 5:35 PM, Ross Zwisler wrote: > >> > The original intent of this series was to add a per-inode DAX flag to ext4 > >> > so that it would be consistent with XFS. In my travels I found and fixed > >> > several related issues in both ext4 and XFS. > >> > >> Hi Ross - > >> > >> hch had a lot of reasons to nuke the dax flag from orbit, and we just > >> /disabled/ it in xfs due to its habit of crashing the kernel... > > > > Ah, sorry, I wasn't CC'd on those threads and missed them. For any interested > > bystanders: > > > > https://www.spinics.net/lists/linux-ext4/msg57840.html > > https://www.spinics.net/lists/linux-xfs/msg09831.html > > https://www.spinics.net/lists/linux-xfs/msg10124.html > > > >> so a couple questions: > >> > >> 1) does this series pass hch's "test the per-inode DAX flag" fstest? > > > > Nope, it has the exact same problems as the XFS per-inode DAX flag. > > > >> 2) do we have an agreement that we need this flag at all, or is this > >> just a parity item because xfs has^whad a per-inode flag? > > > > It was for parity, and because it allows admins finer grained control over > > their system. Basically all things discussed in response to Lukas's original > > patch in the first link above. > > I think it's more than parity. When pmem is slower than page cache it > is actively harmful to have DAX enabled globally for a filesystem. So, > not only should we push for per-inode DAX control, we should also push > to deprecate the mount option. I agree with Christoph that we should > try to automatically and transparently enable DAX where it makes > sense, but we also need a finer-grained mechanism than a mount flag to > force the behavior one way or the other. Yep, agreed. I'll play with how to make this work after I've sorted out all the data corruptions I've found. :) _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com ([134.134.136.100]:42606 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751456AbdIGVNO (ORCPT ); Thu, 7 Sep 2017 17:13:14 -0400 Date: Thu, 7 Sep 2017 15:13:03 -0600 From: Ross Zwisler Subject: Re: [PATCH 0/9] add ext4 per-inode DAX flag Message-ID: <20170907211303.GA23212@linux.intel.com> References: <20170905223541.20594-1-ross.zwisler@linux.intel.com> <20170906170754.GB17663@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Dan Williams Cc: Ross Zwisler , Eric Sandeen , Lukas Czerner , Andrew Morton , "linux-kernel@vger.kernel.org" , "Darrick J. Wong" , Theodore Ts'o , Andreas Dilger , Christoph Hellwig , Dave Chinner , Jan Kara , linux-ext4 , "linux-nvdimm@lists.01.org" , linux-xfs@vger.kernel.org On Thu, Sep 07, 2017 at 01:54:45PM -0700, Dan Williams wrote: > On Wed, Sep 6, 2017 at 10:07 AM, Ross Zwisler > wrote: > > On Tue, Sep 05, 2017 at 09:12:35PM -0500, Eric Sandeen wrote: > >> On 9/5/17 5:35 PM, Ross Zwisler wrote: > >> > The original intent of this series was to add a per-inode DAX flag to ext4 > >> > so that it would be consistent with XFS. In my travels I found and fixed > >> > several related issues in both ext4 and XFS. > >> > >> Hi Ross - > >> > >> hch had a lot of reasons to nuke the dax flag from orbit, and we just > >> /disabled/ it in xfs due to its habit of crashing the kernel... > > > > Ah, sorry, I wasn't CC'd on those threads and missed them. For any interested > > bystanders: > > > > https://www.spinics.net/lists/linux-ext4/msg57840.html > > https://www.spinics.net/lists/linux-xfs/msg09831.html > > https://www.spinics.net/lists/linux-xfs/msg10124.html > > > >> so a couple questions: > >> > >> 1) does this series pass hch's "test the per-inode DAX flag" fstest? > > > > Nope, it has the exact same problems as the XFS per-inode DAX flag. > > > >> 2) do we have an agreement that we need this flag at all, or is this > >> just a parity item because xfs has^whad a per-inode flag? > > > > It was for parity, and because it allows admins finer grained control over > > their system. Basically all things discussed in response to Lukas's original > > patch in the first link above. > > I think it's more than parity. When pmem is slower than page cache it > is actively harmful to have DAX enabled globally for a filesystem. So, > not only should we push for per-inode DAX control, we should also push > to deprecate the mount option. I agree with Christoph that we should > try to automatically and transparently enable DAX where it makes > sense, but we also need a finer-grained mechanism than a mount flag to > force the behavior one way or the other. Yep, agreed. I'll play with how to make this work after I've sorted out all the data corruptions I've found. :)