From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Mario Limonciello <mario.limonciello@dell.com>
Cc: dvhart@infradead.org, LKML <linux-kernel@vger.kernel.org>,
platform-driver-x86@vger.kernel.org,
Richard Hughes <hughsient@gmail.com>,
Yehezkel Bernat <yehezkelshb@gmail.com>
Subject: Re: [PATCH v2] Add driver to force WMI Thunderbolt controller power status
Date: Fri, 8 Sep 2017 11:07:29 +0300 [thread overview]
Message-ID: <20170908080729.GT2477@lahna.fi.intel.com> (raw)
In-Reply-To: <1504810042-4696-1-git-send-email-mario.limonciello@dell.com>
On Thu, Sep 07, 2017 at 01:47:22PM -0500, Mario Limonciello wrote:
I have a small comment which you might want to consider.
> +static int intel_wmi_thunderbolt_probe(struct wmi_device *wdev)
> +{
> + return sysfs_create_group(&wdev->dev.kobj, &tbt_attribute_group);
> +}
> +
> +static int intel_wmi_thunderbolt_remove(struct wmi_device *wdev)
> +{
> + sysfs_remove_group(&wdev->dev.kobj, &tbt_attribute_group);
> + return 0;
> +}
In order to notify userspace about this, what if you send KOBJ_CHANGE
for the wdev when you add/remove this attribute?
next prev parent reply other threads:[~2017-09-08 8:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-07 18:47 [PATCH v2] Add driver to force WMI Thunderbolt controller power status Mario Limonciello
[not found] ` <CA+CmpXvX=iF6R1G6Z-tifi-Nx0uXhfYZzDHFUekOCzbuPBCkrA@mail.gmail.com>
2017-09-07 19:14 ` Bernat, Yehezkel
2017-09-07 20:09 ` Mario.Limonciello
2017-09-07 20:09 ` Mario.Limonciello
2017-09-08 0:06 ` Darren Hart
2017-09-08 8:07 ` Mika Westerberg [this message]
2017-09-08 15:15 ` Mario.Limonciello
2017-09-08 15:15 ` Mario.Limonciello
2017-09-09 4:14 ` Darren Hart
2017-09-09 7:05 ` Mika Westerberg
2017-09-11 9:39 ` Darren Hart
2017-09-11 9:46 ` Mika Westerberg
2017-09-11 21:40 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170908080729.GT2477@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=dvhart@infradead.org \
--cc=hughsient@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@dell.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=yehezkelshb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.