From: Christoph Hellwig <hch@lst.de>
To: Damien Le Moal <damien.lemoal@wdc.com>
Cc: linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>,
Bart Van Assche <Bart.VanAssche@wdc.com>
Subject: Re: [PATCH V2 00/12] scsi-mq support for ZBC disks
Date: Fri, 8 Sep 2017 10:20:40 +0200 [thread overview]
Message-ID: <20170908082040.GA25719@lst.de> (raw)
In-Reply-To: <20170907161640.30465-1-damien.lemoal@wdc.com>
I'm really worried about how this is tied into the sd driver.
>From a quick look it seems like the only thing you really need in
the scheduler that is done through struct scsi_disk is the
offset + len -> zone number lookup - I'd much rather expose this
from sd upwards and keep the scheduler in the block code.
Except for that this looks like a fine approach to me.
next prev parent reply other threads:[~2017-09-08 8:20 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-07 16:16 [PATCH V2 00/12] scsi-mq support for ZBC disks Damien Le Moal
2017-09-07 16:16 ` [PATCH V2 01/12] block: Fix declaration of blk-mq debugfs functions Damien Le Moal
2017-09-08 8:05 ` Johannes Thumshirn
2017-09-08 8:05 ` Johannes Thumshirn
2017-09-07 16:16 ` [PATCH V2 02/12] block: Fix declaration of blk-mq scheduler functions Damien Le Moal
2017-09-08 8:05 ` Johannes Thumshirn
2017-09-08 8:05 ` Johannes Thumshirn
2017-09-07 16:16 ` [PATCH V2 03/12] scsi: sd_zbc: Move ZBC declarations to scsi_proto.h Damien Le Moal
2017-09-08 8:10 ` Johannes Thumshirn
2017-09-08 8:10 ` Johannes Thumshirn
2017-09-07 16:16 ` [PATCH V2 04/12] scsi: sd_zbc: Move zbc disk declarations to sd_zbc.h Damien Le Moal
2017-09-08 8:11 ` Johannes Thumshirn
2017-09-08 8:11 ` Johannes Thumshirn
2017-09-07 16:16 ` [PATCH V2 05/12] scsi: sd_zbc: Fix comments and indentation Damien Le Moal
2017-09-08 8:12 ` Johannes Thumshirn
2017-09-08 8:12 ` Johannes Thumshirn
2017-09-07 16:16 ` [PATCH V2 06/12] scsi: sd_zbc: Rearrange code Damien Le Moal
2017-09-08 8:13 ` Johannes Thumshirn
2017-09-08 8:13 ` Johannes Thumshirn
2017-09-07 16:16 ` [PATCH V2 07/12] scsi: sd_zbc.c: Use well defined macros Damien Le Moal
2017-09-08 8:15 ` Johannes Thumshirn
2017-09-08 8:15 ` Johannes Thumshirn
2017-09-07 16:16 ` [PATCH V2 08/12] scsi: sd_zbc: Fix sd_zbc_read_zoned_characteristics() Damien Le Moal
2017-09-08 8:17 ` Johannes Thumshirn
2017-09-08 8:17 ` Johannes Thumshirn
2017-09-07 16:16 ` [PATCH V2 09/12] scsi: sd_zbc: Limit zone write locking to sequential zones Damien Le Moal
2017-09-08 8:39 ` Johannes Thumshirn
2017-09-08 8:39 ` Johannes Thumshirn
2017-09-08 9:48 ` Christoph Hellwig
2017-09-08 9:50 ` Johannes Thumshirn
2017-09-08 9:50 ` Johannes Thumshirn
2017-09-07 16:16 ` [PATCH V2 10/12] scsi: sd_zbc: Disable zone write locking with scsi-mq Damien Le Moal
2017-09-08 12:43 ` Ming Lei
2017-09-08 16:53 ` Damien Le Moal
2017-09-10 5:10 ` Ming Lei
2017-09-12 8:24 ` Damien Le Moal
2017-09-12 9:26 ` Ming Lei
2017-09-13 0:13 ` Damien Le Moal
2017-09-07 16:16 ` [PATCH V2 11/12] scsi: sd: Introduce scsi_disk_from_queue() Damien Le Moal
2017-09-10 5:16 ` Ming Lei
2017-09-12 8:05 ` Damien Le Moal
2017-09-07 16:16 ` [PATCH V2 12/12] scsi: Introduce ZBC disk I/O scheduler Damien Le Moal
2017-09-08 8:20 ` Christoph Hellwig [this message]
2017-09-08 16:12 ` [PATCH V2 00/12] scsi-mq support for ZBC disks Damien Le Moal
2017-09-11 12:24 ` Christoph Hellwig
2017-09-12 8:38 ` Damien Le Moal
2017-09-13 20:17 ` Christoph Hellwig
2017-09-14 0:04 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170908082040.GA25719@lst.de \
--to=hch@lst.de \
--cc=Bart.VanAssche@wdc.com \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@wdc.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.