From: "Daniel P. Berrange" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: famz@redhat.com, brak@vultr.com, f4bug@amsat.org
Subject: Re: [Qemu-devel] [PATCH v2 0/3] Improve websock response / error handling
Date: Fri, 8 Sep 2017 14:41:45 +0100 [thread overview]
Message-ID: <20170908134145.GF32645@redhat.com> (raw)
In-Reply-To: <150486803677.210.12147319216227977632@6d89bd104fc3>
On Fri, Sep 08, 2017 at 03:53:57AM -0700, no-reply@patchew.org wrote:
> /tmp/qemu-test/src/io/channel-websock.c: In function ‘qio_channel_websock_date_str’:
> /tmp/qemu-test/src/io/channel-websock.c:171: error: ‘GTimeZone’ undeclared (first use in this function)
> /tmp/qemu-test/src/io/channel-websock.c:171: error: (Each undeclared identifier is reported only once
> /tmp/qemu-test/src/io/channel-websock.c:171: error: for each function it appears in.)
> /tmp/qemu-test/src/io/channel-websock.c:171: error: ‘utc’ undeclared (first use in this function)
> /tmp/qemu-test/src/io/channel-websock.c:171: warning: implicit declaration of function ‘g_time_zone_new_utc’
> /tmp/qemu-test/src/io/channel-websock.c:171: warning: nested extern declaration of ‘g_time_zone_new_utc’
> /tmp/qemu-test/src/io/channel-websock.c:172: error: ‘GDateTime’ undeclared (first use in this function)
> /tmp/qemu-test/src/io/channel-websock.c:172: error: ‘now’ undeclared (first use in this function)
> /tmp/qemu-test/src/io/channel-websock.c:172: warning: implicit declaration of function ‘g_date_time_new_now’
> /tmp/qemu-test/src/io/channel-websock.c:172: warning: nested extern declaration of ‘g_date_time_new_now’
> /tmp/qemu-test/src/io/channel-websock.c:173: warning: implicit declaration of function ‘g_date_time_format’
> /tmp/qemu-test/src/io/channel-websock.c:173: warning: nested extern declaration of ‘g_date_time_format’
> /tmp/qemu-test/src/io/channel-websock.c:175: warning: implicit declaration of function ‘g_date_time_unref’
> /tmp/qemu-test/src/io/channel-websock.c:175: warning: nested extern declaration of ‘g_date_time_unref’
> /tmp/qemu-test/src/io/channel-websock.c:176: warning: implicit declaration of function ‘g_time_zone_unref’
> /tmp/qemu-test/src/io/channel-websock.c:176: warning: nested extern declaration of ‘g_time_zone_unref’
Urgh, GTimeZone arrived in glib 2.26 and we hav 2.22 as the min :-(
I'll have to switch to strftime....
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
prev parent reply other threads:[~2017-09-08 13:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-08 10:30 [Qemu-devel] [PATCH v2 0/3] Improve websock response / error handling Daniel P. Berrange
2017-09-08 10:30 ` [Qemu-devel] [PATCH v2 1/3] io: send proper HTTP response for websocket errors Daniel P. Berrange
2017-09-08 10:30 ` [Qemu-devel] [PATCH v2 2/3] io: include full error message in websocket handshake trace Daniel P. Berrange
2017-09-08 10:30 ` [Qemu-devel] [PATCH v2 3/3] io: use case insensitive check for Connection & Upgrade websock headers Daniel P. Berrange
2017-09-08 13:22 ` Philippe Mathieu-Daudé
2017-09-08 13:26 ` Daniel P. Berrange
2017-09-08 10:53 ` [Qemu-devel] [PATCH v2 0/3] Improve websock response / error handling no-reply
2017-09-08 13:41 ` Daniel P. Berrange [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170908134145.GF32645@redhat.com \
--to=berrange@redhat.com \
--cc=brak@vultr.com \
--cc=f4bug@amsat.org \
--cc=famz@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.