From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] smcroute: bump to version 2.3.1
Date: Sat, 9 Sep 2017 23:05:52 +0200 [thread overview]
Message-ID: <20170909230552.782b38b8@windsurf.lan> (raw)
In-Reply-To: <20170907130908.22964-1-thomas.faivre@6wind.com>
Hello,
On Thu, 7 Sep 2017 15:09:08 +0200, Thomas Faivre wrote:
> Signed-off-by: Thomas Faivre <thomas.faivre@6wind.com>
Since the patch is doing more than a version bump, it would have be
good to have a short note in the commit log about the added libcap
optional dependency (especially how it's related to the version bump).
> +ifeq ($(BR2_PACKAGE_LIBCAP),y)
> +SMCROUTE_DEPENDENCIES = libcap
We like to explicitly pass --with-libcap here, so I've adjusted your
patch accordingly.
Applied to master with those two nits fixed. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
prev parent reply other threads:[~2017-09-09 21:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-07 13:09 [Buildroot] [PATCH 1/1] smcroute: bump to version 2.3.1 Thomas Faivre
2017-09-09 21:05 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170909230552.782b38b8@windsurf.lan \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.