All of lore.kernel.org
 help / color / mirror / Atom feed
From: Clayton Craft <clayton@craftyguy.net>
To: ofono@ofono.org
Subject: [PATCH 1/1] isimodem: Use correct callback for pin status
Date: Sun, 10 Sep 2017 09:41:28 -0700	[thread overview]
Message-ID: <20170910164128.GA3@computer.craftyguy.net> (raw)
In-Reply-To: <20170909203404.GG3@computer.craftyguy.net>

[-- Attachment #1: Type: text/plain, Size: 1352 bytes --]

This fixes the segfault I experienced on enabling the modem by using
the correct callback for pin status response.


 drivers/isimodem/sim.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/isimodem/sim.c b/drivers/isimodem/sim.c
index 4379a159..cea50972 100644
--- a/drivers/isimodem/sim.c
+++ b/drivers/isimodem/sim.c
@@ -450,7 +450,7 @@ static void check_sec_response(const GIsiMessage *msg, void *opaque,
 					uint8_t success, uint8_t failure)
 {
 	struct isi_cb_data *cbd = opaque;
-	ofono_sim_lock_unlock_cb_t cb = cbd->cb;
+	ofono_query_facility_lock_cb_t cb = cbd->cb;
 	struct ofono_sim *sim = cbd->user;
 	uint8_t id;
 	uint8_t cause;
@@ -465,7 +465,7 @@ static void check_sec_response(const GIsiMessage *msg, void *opaque,
 	if (id == success) {
 		DBG("%s", sec_message_id_name(id));
 		sim_set_passwd_state(sim, OFONO_SIM_PASSWORD_NONE);
-		CALLBACK_WITH_SUCCESS(cb, cbd->data);
+		CALLBACK_WITH_SUCCESS(cb, OFONO_SIM_PASSWORD_NONE, sim);
 		return;
 	}

@@ -478,7 +478,7 @@ static void check_sec_response(const GIsiMessage *msg, void *opaque,
 		DBG("Error msg: %s", sec_message_id_name(id));

 failure:
-	CALLBACK_WITH_FAILURE(cb, cbd->data);
+	CALLBACK_WITH_FAILURE(cb, -1, cbd->data);
 }

 static void sec_code_verify_resp(const GIsiMessage *msg, void *opaque)


  reply	other threads:[~2017-09-10 16:41 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-08  0:51 nokia-modem (N900) not detected after migration to udevng Clayton Craft
2017-09-08  1:13 ` Jonas Bonn
2017-09-08  1:17   ` Clayton Craft
2017-09-08  1:29     ` Jonas Bonn
2017-09-08  1:38       ` Clayton Craft
2017-09-08  2:12         ` Jonas Bonn
2017-09-09  3:09           ` Clayton Craft
2017-09-09  8:56             ` [PATCH 1/1] udev: add serial_info struct to modem Jonas Bonn
2017-09-09  9:05               ` Jonas Bonn
2017-09-09 17:40                 ` Clayton Craft
2017-09-09 17:58           ` nokia-modem (N900) not detected after migration to udevng Clayton Craft
2017-09-09 18:29             ` Denis Kenzior
2017-09-09 18:43               ` Clayton Craft
2017-09-09 20:34               ` Clayton Craft
2017-09-10 16:41                 ` Clayton Craft [this message]
2017-09-10 17:47                   ` [PATCH 1/1] isimodem: Use correct callback for pin status Denis Kenzior
2017-09-10 18:41                     ` Clayton Craft
2017-09-11 15:37                       ` Denis Kenzior
2017-09-11 15:44               ` nokia-modem (N900) not detected after migration to udevng Clayton Craft
2017-09-11 18:49                 ` Denis Kenzior
2017-09-11 19:54                   ` Clayton Craft
2017-09-12  7:51                     ` Jonas Bonn
2017-09-12  8:11                       ` [PATCH 1/2] udev: fixes for detection of non-USB modems Jonas Bonn
2017-09-12  8:11                         ` [PATCH 2/2] udev: isi modems do not use 'Device' property Jonas Bonn
2017-09-12 17:28                         ` [PATCH 1/2] udev: fixes for detection of non-USB modems Denis Kenzior
2017-09-08  3:17         ` [PATCH 1/1] udev: devnode is not a required modem property Jonas Bonn
2017-09-08  6:06           ` Clayton Craft
2017-09-08  8:07             ` [PATCH 1/1] udev: set driver for serial drivers Jonas Bonn
2017-09-08 15:25               ` Clayton Craft

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170910164128.GA3@computer.craftyguy.net \
    --to=clayton@craftyguy.net \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.