From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: David Ahern <dsahern@gmail.com>
Cc: Milian Wolff <milian.wolff@kdab.com>,
acme@kernel.org, Linux-kernel@vger.kernel.org,
linux-perf-users@vger.kernel.org,
Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Yao Jin <yao.jin@linux.intel.com>
Subject: Re: [PATCH] perf: support running perf binaries with a dash in their name
Date: Mon, 11 Sep 2017 11:33:12 -0300 [thread overview]
Message-ID: <20170911143312.GD5054@redhat.com> (raw)
In-Reply-To: <b7c2b440-f781-19ae-ebc7-7fba93bb4618@gmail.com>
Em Mon, Sep 11, 2017 at 07:08:18AM -0700, David Ahern escreveu:
> On 9/11/17 4:14 AM, Milian Wolff wrote:
> > Previously the part behind "perf-" was interpreted as an internal
> > perf command. If the suffix could not be handled, the execution
<SNIP>
> > --- a/tools/perf/perf.c
> > - fprintf(stderr, "cannot handle %s internally", cmd);
> > - goto out;
> > + // if the command is handled, the above function does not return
> > + // undo changes and fall through in such a case
> Those should be /* */ not //
>
> > + cmd -= 5;
> > + argv[0] = cmd;
> > }
> > if (strstarts(cmd, "trace")) {
> > #ifdef HAVE_LIBAUDIT_SUPPORT
> other than that LGTM and long over due.
> Acked-by: David Ahern <dsahern@gmail.com>
We got those from git, agreed it should go, thanks for the Acked-by,
always welcome!
- Arnaldo
next prev parent reply other threads:[~2017-09-11 14:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-11 11:14 [PATCH] perf: support running perf binaries with a dash in their name Milian Wolff
2017-09-11 14:08 ` David Ahern
2017-09-11 14:33 ` Arnaldo Carvalho de Melo [this message]
2017-09-11 15:16 ` Milian Wolff
2017-09-11 15:38 ` Arnaldo Carvalho de Melo
2017-09-13 7:46 ` [tip:perf/urgent] perf tools: Support " tip-bot for Milian Wolff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170911143312.GD5054@redhat.com \
--to=acme@redhat.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=dsahern@gmail.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=milian.wolff@kdab.com \
--cc=namhyung@kernel.org \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.