From: Greg KH <gregkh@linuxfoundation.org>
To: Shreeya Patel <shreeya.patel23498@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [PATCH v4] Staging: rtlwifi: Remove unnecessary 'out of memory' message.
Date: Mon, 11 Sep 2017 09:32:10 -0700 [thread overview]
Message-ID: <20170911163210.GA26981@kroah.com> (raw)
In-Reply-To: <1505036405-3702-1-git-send-email-shreeya.patel23498@gmail.com>
On Sun, Sep 10, 2017 at 03:10:05PM +0530, Shreeya Patel wrote:
> Logging messages that show some type of 'out of memory' error
> are generally unnecessary as there is a generic message and
> a stack dump done by the memory subsystem.
>
> These messages generally increase kernel size without much
> added value.
>
> Problem found by checkpatch.
>
> Signed-off-by: Shreeya Patel <shreeya.patel23498@gmail.com>
> Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
>
> Changes in v4:
> -Include v2 and v3 in the patch.
>
> Changes in v3:
> -Make the commit message more appropriate.
>
> changes in v2:
> -Original patch was not sent to the mailing list.
> Also, add a tab before the return statement.
>
> drivers/staging/rtlwifi/rc.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/staging/rtlwifi/rc.c b/drivers/staging/rtlwifi/rc.c
> index 65de0c7..779a5c6 100644
> --- a/drivers/staging/rtlwifi/rc.c
> +++ b/drivers/staging/rtlwifi/rc.c
> @@ -281,10 +281,8 @@ static void *rtl_rate_alloc_sta(void *ppriv,
> struct rtl_rate_priv *rate_priv;
>
> rate_priv = kzalloc(sizeof(*rate_priv), gfp);
> - if (!rate_priv) {
> - pr_err("Unable to allocate private rc structure\n");
> + if (!rate_priv)
> return NULL;
> - }
>
> rtlpriv->rate_priv = rate_priv;
>
This patch is sent corrupted (leading space is gone), and git doesn't
like it. Can you please fix it up and resend?
thanks,
greg k-h
next prev parent reply other threads:[~2017-09-11 16:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-10 9:40 [PATCH v4] Staging: rtlwifi: Remove unnecessary 'out of memory' message Shreeya Patel
2017-09-10 10:13 ` [Outreachy kernel] " Julia Lawall
2017-09-11 16:32 ` Greg KH [this message]
2017-09-11 16:18 ` Shreeya Patel
2017-09-11 16:57 ` Greg KH
2017-09-11 17:00 ` Shreeya Patel
2017-09-11 17:01 ` [Outreachy kernel] " Julia Lawall
2017-09-11 17:04 ` Shreeya Patel
2017-09-11 17:11 ` Julia Lawall
2017-09-11 17:14 ` Shreeya Patel
2017-09-11 17:19 ` Shreeya Patel
2017-09-11 17:25 ` Julia Lawall
2017-09-11 17:29 ` Shreeya Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170911163210.GA26981@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=shreeya.patel23498@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.