From: Kevin Wolf <kwolf@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Eric Blake <eblake@redhat.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 01/12] qemu-iotests: remove dead code
Date: Tue, 12 Sep 2017 12:00:08 +0200 [thread overview]
Message-ID: <20170912100008.GD29136@localhost.localdomain> (raw)
In-Reply-To: <186485494.2838970.1502318620647.JavaMail.zimbra@redhat.com>
Am 10.08.2017 um 00:43 hat Paolo Bonzini geschrieben:
>
>
> ----- Original Message -----
> > From: "Eric Blake" <eblake@redhat.com>
> > To: "Paolo Bonzini" <pbonzini@redhat.com>, qemu-devel@nongnu.org
> > Cc: kwolf@redhat.com, qemu-block@nongnu.org
> > Sent: Thursday, August 10, 2017 12:18:54 AM
> > Subject: Re: [Qemu-devel] [PATCH 01/12] qemu-iotests: remove dead code
> >
> > On 08/09/2017 04:54 PM, Paolo Bonzini wrote:
> > > This includes shell function, shell variables, command line options
> > > (randomize.awk does not exist) and conditions that can never be true
> > > (./qemu does not exist anymore).
> >
> > Can we point to a commit id where we stopped making ./qemu?
>
> commit 9aed1e036dc0de49d08d713f9e5c4655e94acb56
> Author: Anthony Liguori <aliguori@us.ibm.com>
> Date: Mon Aug 29 09:55:36 2011 -0500
>
> Rename qemu -> qemu-system-i386
>
> This has been discussed before in the past. The special casing really makes no
> sense anymore. This seems like a good change to make for 1.0.
>
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
This is not related to ./qemu in the qemu-iotests directory. It's just
the name of the binary that is created in i386-softmmu/, but that has
never been the working directory for qemu-iotests.
> > Is it still worth supporting a local symlink?
>
> Not sure who would have one...
I have always been using symlinks in the qemu-iotests directory. And, as
you probably expect now, ./qemu does exist in my setup.
Now, I must admit that I haven't actually made real use of it recently
because the symlinks only point to the binaries that qemu-iotests would
pick up anyway. But when running qemu-iotests against a different qemu
version or installed binaries instead of whatever is in the build tree,
I always found the symlinks more convenient that setting up a bunch of
environment variables.
So maybe supporting them isn't completely useless.
Kevin
next prev parent reply other threads:[~2017-09-12 10:00 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 21:54 [Qemu-devel] [PATCH 00/12] cleanup qemu-iotests Paolo Bonzini
2017-08-09 21:54 ` [Qemu-devel] [PATCH 01/12] qemu-iotests: remove dead code Paolo Bonzini
2017-08-09 22:18 ` Eric Blake
2017-08-09 22:43 ` Paolo Bonzini
2017-09-12 10:00 ` Kevin Wolf [this message]
2017-08-10 9:53 ` [Qemu-devel] [Qemu-block] " Paolo Bonzini
2017-08-09 21:55 ` [Qemu-devel] [PATCH 02/12] qemu-iotests: get rid of AWK_PROG Paolo Bonzini
2017-08-09 22:21 ` Eric Blake
2017-08-09 22:28 ` Philippe Mathieu-Daudé
2017-08-09 21:55 ` [Qemu-devel] [PATCH 03/12] qemu-iotests: move "check" code out of common.rc Paolo Bonzini
2017-08-09 22:27 ` Philippe Mathieu-Daudé
2017-08-09 21:55 ` [Qemu-devel] [PATCH 04/12] qemu-iotests: limit non-_PROG-suffixed variables to common.rc Paolo Bonzini
2017-09-12 10:31 ` Kevin Wolf
2017-09-12 12:28 ` Paolo Bonzini
2017-09-12 12:51 ` Kevin Wolf
2017-09-12 12:55 ` Paolo Bonzini
2017-08-09 21:55 ` [Qemu-devel] [PATCH 05/12] qemu-iotests: do not include common.rc in "check" Paolo Bonzini
2017-08-09 22:26 ` Philippe Mathieu-Daudé
2017-08-09 21:55 ` [Qemu-devel] [PATCH 06/12] qemu-iotests: do not do useless search for QEMU_*_PROG Paolo Bonzini
2017-08-09 21:55 ` [Qemu-devel] [PATCH 07/12] qemu-iotests: disintegrate more parts of common.config Paolo Bonzini
2017-09-12 10:40 ` Kevin Wolf
2017-09-12 12:31 ` Paolo Bonzini
2017-09-12 12:57 ` Kevin Wolf
2017-09-12 13:02 ` Paolo Bonzini
2017-08-09 21:55 ` [Qemu-devel] [PATCH 08/12] qemu-iotests: fix uninitialized variable Paolo Bonzini
2017-08-10 9:17 ` Markus Armbruster
2017-08-09 21:55 ` [Qemu-devel] [PATCH 09/12] qemu-iotests: do not search for binaries in the current directory Paolo Bonzini
2017-08-10 9:18 ` Markus Armbruster
2017-08-09 21:55 ` [Qemu-devel] [PATCH 10/12] qemu-iotests: get rid of $iam Paolo Bonzini
2017-08-09 22:23 ` Philippe Mathieu-Daudé
2017-08-09 21:55 ` [Qemu-devel] [PATCH 11/12] qemu-iotests: include common.env and common.config early Paolo Bonzini
2017-08-09 21:55 ` [Qemu-devel] [PATCH 12/12] qemu-iotests: merge "check" and "common" Paolo Bonzini
2017-09-11 22:22 ` [Qemu-devel] [Qemu-block] [PATCH 00/12] cleanup qemu-iotests John Snow
2017-09-11 22:31 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170912100008.GD29136@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=eblake@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.