From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrien Mazarguil Subject: Re: [PATCH] net/mlx5: fix tunnel_en initialization value Date: Tue, 12 Sep 2017 12:19:29 +0200 Message-ID: <20170912101929.GM2481@6wind.com> References: <201709120914.v8C9Evq8012512@mse01.zte.com.cn> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: nelio.laranjeiro@6wind.com, dev@dpdk.org To: Congwen Zhang Return-path: Received: from mail-wr0-f178.google.com (mail-wr0-f178.google.com [209.85.128.178]) by dpdk.org (Postfix) with ESMTP id E1DDC2BA4 for ; Tue, 12 Sep 2017 12:19:39 +0200 (CEST) Received: by mail-wr0-f178.google.com with SMTP id o42so20200850wrb.3 for ; Tue, 12 Sep 2017 03:19:39 -0700 (PDT) Content-Disposition: inline In-Reply-To: <201709120914.v8C9Evq8012512@mse01.zte.com.cn> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Congwen, On Tue, Sep 12, 2017 at 05:05:50PM +0800, Congwen Zhang wrote: > In function mlx5_pci_probe(), tunnel_en actually be used without > being initialized. Fix it by initializing it to 0. > > Signe-off-by: Congwen Zhang Thanks, however it's already been addressed [1]. The related commit is only part of dpdk-next-net though, it's not merged in the main tree yet. [1] http://dpdk.org/ml/archives/dev/2017-September/074271.html > --- > drivers/net/mlx5/mlx5.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c > index b7e5046..95e62ad 100644 > --- a/drivers/net/mlx5/mlx5.c > +++ b/drivers/net/mlx5/mlx5.c > @@ -452,7 +452,7 @@ struct mlx5_args { > struct ibv_device_attr device_attr; > unsigned int sriov; > unsigned int mps; > - unsigned int tunnel_en; > + unsigned int tunnel_en = 0; > int idx; > int i; > > -- > 1.8.3.1 > -- Adrien Mazarguil 6WIND