From: "Daniel P. Berrange" <berrange@redhat.com>
To: Michal Privoznik <mprivozn@redhat.com>
Cc: qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH v5 2/3] watchdog.h: Drop local redefinition of actions enum
Date: Tue, 12 Sep 2017 14:02:15 +0100 [thread overview]
Message-ID: <20170912130215.GH17633@redhat.com> (raw)
In-Reply-To: <ce2790634e6a1b3b6cf90462399d17bad83f0290.1504771369.git.mprivozn@redhat.com>
On Thu, Sep 07, 2017 at 10:05:25AM +0200, Michal Privoznik wrote:
> We already have enum that enumerates all the actions that a
> watchdog can take when hitting its timeout: WatchdogAction.
> Use that instead of inventing our own.
>
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
> hw/watchdog/watchdog.c | 45 ++++++++++++++++++++-------------------------
> hw/watchdog/wdt_diag288.c | 6 +++---
> include/sysemu/watchdog.h | 12 ++----------
> 3 files changed, 25 insertions(+), 38 deletions(-)
Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2017-09-12 13:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-07 8:05 [Qemu-devel] [PATCH v5 0/3] watchdog.h: Drop local redefinition of actions enum Michal Privoznik
2017-09-07 8:05 ` [Qemu-devel] [PATCH v5 1/3] qapi: Rename WatchdogExpirationAction enum Michal Privoznik
2017-09-12 13:00 ` Daniel P. Berrange
2017-09-07 8:05 ` [Qemu-devel] [PATCH v5 2/3] watchdog.h: Drop local redefinition of actions enum Michal Privoznik
2017-09-12 13:02 ` Daniel P. Berrange [this message]
2017-09-07 8:05 ` [Qemu-devel] [PATCH v5 3/3] watchdog: Allow setting action on the fly Michal Privoznik
2017-09-12 13:04 ` Daniel P. Berrange
2017-10-02 6:49 ` Markus Armbruster
2017-09-07 13:35 ` [Qemu-devel] [PATCH v5 0/3] watchdog.h: Drop local redefinition of actions enum Eric Blake
2017-09-07 13:47 ` Markus Armbruster
2017-09-22 13:14 ` Michal Privoznik
2017-10-02 6:54 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170912130215.GH17633@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=mprivozn@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.