Re: [PATCH v8 3/3] kernel-devicetree.bbclass: Add support to generate append to kernel

[Andreas Oberritter <obi@opendreambox.org>]

On Tue, 12 Sep 2017 14:00:43 -0300
Otavio Salvador <otavio.salvador@ossystems.com.br> wrote:

> Hello Andreas,
> 
> On Tue, Sep 12, 2017 at 11:45 AM, Andreas Oberritter
> <obi@opendreambox.org> wrote:
> > Hi Otavio,
> >
> > On Tue, 12 Sep 2017 10:45:51 -0300
> > Otavio Salvador <otavio@ossystems.com.br> wrote:
> >  
> >> +do_configure_devicetree() {
> >> +     if [ "${KERNEL_DEVICETREE_BUNDLE}" = "1" ]; then
> >> +             if echo ${KERNEL_IMAGETYPE_FOR_MAKE} | grep -q 'zImage'; then
> >> +                     config="${B}/.config"
> >> +                     if ! grep -q 'CONFIG_ARM_APPENDED_DTB=y' $config; then
> >> +                             bbwarn 'CONFIG_ARM_APPENDED_DTB is NOT enabled in the kernel. Enabling it to allow the kernel to boot with the Device Tree appended!'
> >> +                             sed -i "/CONFIG_ARM_APPENDED_DTB[ =]/d" $config
> >> +                             echo "CONFIG_ARM_APPENDED_DTB=y" >> $config
> >> +                             echo "# CONFIG_ARM_ATAG_DTB_COMPAT is not set" >> $config  
> >
> > what about CONFIG_MIPS_APPENDED_DTB?
> >
> > Can we ever make sure to cover all relevant architectures?  
> 
> I don't know the details about the MIPS and its appended DTB support.
> Do you know what we need?
 
Just the symbol already mentioned above, see [1].

However, I'd argue that the verification of configuration options specific to one
or two architectures shouldn't be done here at all. Users are responsible to choose
suitable kernel options.

Regards,
Andreas

[1]: https://dev.openwrt.org/browser/trunk/target/linux/brcm63xx/patches-4.1/366-MIPS-add-support-for-vmlinux.bin-appended-DTB.patch?rev=46113