From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:58323 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751612AbdINMmj (ORCPT ); Thu, 14 Sep 2017 08:42:39 -0400 Date: Thu, 14 Sep 2017 14:41:08 +0200 From: David Sterba To: Naohiro Aota Cc: linux-btrfs@vger.kernel.org Subject: Re: [PATCH 1/2] btrfs-progs: build: generate all dependency files Message-ID: <20170914124108.GS29043@suse.cz> Reply-To: dsterba@suse.cz References: <150538384653.24503.41288304442819820.stgit@naota.dhcp.fujisawa.hgst.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <150538384653.24503.41288304442819820.stgit@naota.dhcp.fujisawa.hgst.com> Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Thu, Sep 14, 2017 at 07:10:46PM +0900, Naohiro Aota wrote: > We're missing several dependency files like: > > $ diff -u <(find -name '*.o'|cut -d. -f2|sort) <(find -name '*.o.d'|cut -d. -f2|sort) > --- /proc/self/fd/11 2017-09-14 18:17:44.460564620 +0900 > +++ /proc/self/fd/12 2017-09-14 18:17:44.460564620 +0900 Please note that an actual diff in the changelog is understood as start of the patch by git-am, indenting the --- or +++ lines makes it work again. > @@ -3,7 +3,6 @@ > /btrfs-corrupt-block > /btrfs-debug-tree > /btrfs-find-root > -/btrfs-list > /btrfs-map-logical > /btrfs-select-super > /btrfstune > @@ -29,11 +28,6 @@ > /cmds-scrub > /cmds-send > /cmds-subvolume > -/convert/common > -/convert/main > -/convert/source-ext2 > -/convert/source-fs > -/convert/source-reiserfs > /ctree > /dir-item > /disk-io > > > This is due to moving things out of objects and cmds_objects variables. Such > missing dependency files cause mis-building of some source files (try touch > utils.h; make mkfs/main.o). > > This patch introduce a new variable "all_objects" to keep all the objects and > use the variable to generate proper dependency file building rules. > > Signed-off-by: Naohiro Aota Applied, thanks.