From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Remove uused 'in_vbl' from i915_get_crtc_scanoutpos()
Date: Thu, 14 Sep 2017 20:42:14 +0300 [thread overview]
Message-ID: <20170914174214.GC4914@intel.com> (raw)
In-Reply-To: <20170914164213.18461-1-chris@chris-wilson.co.uk>
On Thu, Sep 14, 2017 at 05:42:13PM +0100, Chris Wilson wrote:
> Commit 1bf6ad622b9b ("drm/vblank: drop the mode argument from
> drm_calc_vbltimestamp_from_scanoutpos") removed the use of in_vbl, but
> did not remove the local variable. Do so now.
>
> Fixes: 1bf6ad622b9b ("drm/vblank: drop the mode argument from drm_calc_vbltimestamp_from_scanoutpos")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_irq.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index 91a2c5dbf2da..066a6b355cf1 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -839,7 +839,6 @@ static bool i915_get_crtc_scanoutpos(struct drm_device *dev, unsigned int pipe,
> pipe);
> int position;
> int vbl_start, vbl_end, hsync_start, htotal, vtotal;
> - bool in_vbl = true;
> unsigned long irqflags;
>
> if (WARN_ON(!mode->crtc_clock)) {
> @@ -922,8 +921,6 @@ static bool i915_get_crtc_scanoutpos(struct drm_device *dev, unsigned int pipe,
>
> spin_unlock_irqrestore(&dev_priv->uncore.lock, irqflags);
>
> - in_vbl = position >= vbl_start && position < vbl_end;
> -
> /*
> * While in vblank, position will be negative
> * counting up towards 0 at vbl_end. And outside
> --
> 2.14.1
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-09-14 17:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-14 16:42 [PATCH] drm/i915: Remove uused 'in_vbl' from i915_get_crtc_scanoutpos() Chris Wilson
2017-09-14 17:06 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-09-14 17:42 ` Ville Syrjälä [this message]
2017-09-15 9:58 ` [PATCH] " Chris Wilson
2017-09-14 23:00 ` ✓ Fi.CI.IGT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170914174214.GC4914@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.