From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Vinod Koul <vinod.koul@intel.com>,
Fabio Estevam <fabio.estevam@nxp.com>,
Dan Williams <dan.j.williams@intel.com>,
dmaengine@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] dmaengine: imx-sdma: Correct src_addr_widths and directions
Date: Thu, 14 Sep 2017 14:49:08 -0700 [thread overview]
Message-ID: <20170914214907.GA29201@Asurada-Nvidia> (raw)
In-Reply-To: <CAOMZO5CA3pw02H=qs1OTnZ3DVoMhnYRuYYmDpYMZYkmnwWAy2Q@mail.gmail.com>
On Thu, Sep 14, 2017 at 04:43:08PM -0300, Fabio Estevam wrote:
> Hi Nicolin,
>
> On Thu, Sep 14, 2017 at 3:46 PM, Nicolin Chen <nicoleotsuka@gmail.com> wrote:
> > The driver already supports DMA_DEV_TO_DEV in sdma_config(),
> > DMA_SLAVE_BUSWIDTH_2_BYTES and DMA_SLAVE_BUSWIDTH_1_BYTE in
> > sdma_prep_slave_sg(). So this patch adds them to the lists.
> >
> > Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com>
>
> Patch looks good.
>
> Just curious: what is the specific usecase that triggered this change?
Any audio test case. The ASoC generic dmaengine gets the DMA
cap (4_BYTES only) and apply it to hw->formats in ASoC core.
SSI + WM8962 could have S8_LE, S16_LE and S24_LE formats but
it turns out that it only has S24_LE now because of this.
I haven't seen any side effect by DMA_DEV_TO_DEV yet but it
could potentially break ASRC once a similar constrain based
on the "directions" is applied.
next prev parent reply other threads:[~2017-09-14 21:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-14 18:46 [PATCH v2] dmaengine: imx-sdma: Correct src_addr_widths and directions Nicolin Chen
2017-09-14 19:43 ` Fabio Estevam
2017-09-14 21:49 ` Nicolin Chen [this message]
2017-09-21 17:16 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170914214907.GA29201@Asurada-Nvidia \
--to=nicoleotsuka@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=festevam@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.