From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [PATCH v2 1/5] soc: qcom: smem: Use le32_to_cpu for partition size comparison Date: Thu, 14 Sep 2017 18:08:54 -0700 Message-ID: <20170915010854.GO2016@tuxbook> References: <1505424302-29147-1-git-send-email-clew@codeaurora.org> <1505424302-29147-2-git-send-email-clew@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1505424302-29147-2-git-send-email-clew@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org To: Chris Lew Cc: andy.gross@linaro.org, david.brown@linaro.org, aneela@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org On Thu 14 Sep 14:24 PDT 2017, Chris Lew wrote: > Endianness can vary in the system, add le32_to_cpu when comparing > size values from smem. > > Signed-off-by: Chris Lew Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > > Changes since v1: > - New change > > drivers/soc/qcom/smem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/qcom/smem.c b/drivers/soc/qcom/smem.c > index c28275be0038..db04c45d4132 100644 > --- a/drivers/soc/qcom/smem.c > +++ b/drivers/soc/qcom/smem.c > @@ -698,7 +698,7 @@ static int qcom_smem_enumerate_partitions(struct qcom_smem *smem, > return -EINVAL; > } > > - if (header->size != entry->size) { > + if (le32_to_cpu(header->size) != le32_to_cpu(entry->size)) { > dev_err(smem->dev, > "Partition %d has invalid size\n", i); > return -EINVAL; > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >