Re: [PATCH rdma-next] RDMA/bnxt_re: Remove redundant fw_ver sysfs entry

[Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 2424 bytes --]

On Fri, Sep 15, 2017 at 10:51:58AM +0530, Somnath Kotur wrote:
> Hi Leon,
>                 Thanks for the patch, however this will not compile as
> the corresponding entry from the bnxt_re_attributes[] was not removed.
> Having said that, there is already a patch in the works in my sandbox
> that addresses this area that i plan to push as part of features
> patchset right after my recent bug-fixes patch series is accepted.
> So we could drop this for now and wait for the patch series that will
> address this please ?

Thanks for catching it, your driver is dependent on CONFIG_DCB and it
wasn't enabled in my default config.

>
> Thanks
> Som
>
> On Thu, Sep 14, 2017 at 6:51 PM, Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> > The IB/core has general sysfs knob to print FW version.
> > This eliminates the need for the custom bnxt_re implementation,
> > which is similar to the general.
> >
> > Cc: Somnath Kotur <somnath.kotur-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
> > Signed-off-by: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> > ---
> >  drivers/infiniband/hw/bnxt_re/main.c | 9 ---------
> >  1 file changed, 9 deletions(-)
> >
> > diff --git a/drivers/infiniband/hw/bnxt_re/main.c b/drivers/infiniband/hw/bnxt_re/main.c
> > index ceae2d92fb08..c686887bf71e 100644
> > --- a/drivers/infiniband/hw/bnxt_re/main.c
> > +++ b/drivers/infiniband/hw/bnxt_re/main.c
> > @@ -525,14 +525,6 @@ static ssize_t show_rev(struct device *device, struct device_attribute *attr,
> >         return scnprintf(buf, PAGE_SIZE, "0x%x\n", rdev->en_dev->pdev->vendor);
> >  }
> >
> > -static ssize_t show_fw_ver(struct device *device, struct device_attribute *attr,
> > -                          char *buf)
> > -{
> > -       struct bnxt_re_dev *rdev = to_bnxt_re_dev(device, ibdev.dev);
> > -
> > -       return scnprintf(buf, PAGE_SIZE, "%s\n", rdev->dev_attr.fw_ver);
> > -}
> > -
> >  static ssize_t show_hca(struct device *device, struct device_attribute *attr,
> >                         char *buf)
> >  {
> > @@ -542,7 +534,6 @@ static ssize_t show_hca(struct device *device, struct device_attribute *attr,
> >  }
> >
> >  static DEVICE_ATTR(hw_rev, 0444, show_rev, NULL);
> > -static DEVICE_ATTR(fw_rev, 0444, show_fw_ver, NULL);
> >  static DEVICE_ATTR(hca_type, 0444, show_hca, NULL);
> >
> >  static struct device_attribute *bnxt_re_attributes[] = {
> > --
> > 2.14.1
> >

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]