From: Mauro Carvalho Chehab <mchehab@s-opensource.com>
To: Linux Media Mailing List <linux-media@vger.kernel.org>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
Max Kellermann <max.kellermann@gmail.com>,
Shuah Khan <shuah@kernel.org>,
Colin Ian King <colin.king@canonical.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Ingo Molnar <mingo@kernel.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Michael Ira Krufky <mkrufky@linuxtv.org>
Subject: Re: [PATCH 5/5] media: dvb_frontend: get rid of set_property() callback
Date: Fri, 15 Sep 2017 07:05:54 -0300 [thread overview]
Message-ID: <20170915070554.52b6f145@vento.lan> (raw)
In-Reply-To: <e62a34ca2d5ef94b041e723892b6c5c36d466fbe.1505466580.git.mchehab@s-opensource.com>
Em Fri, 15 Sep 2017 06:11:01 -0300
Mauro Carvalho Chehab <mchehab@s-opensource.com> escreveu:
> Now that all clients of set_property() were removed, get rid
> of this callback.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
> ---
> drivers/media/dvb-core/dvb_frontend.c | 7 -------
> drivers/media/dvb-core/dvb_frontend.h | 2 --
> 2 files changed, 9 deletions(-)
>
> diff --git a/drivers/media/dvb-core/dvb_frontend.c b/drivers/media/dvb-core/dvb_frontend.c
> index 5d00e46d9432..8abe4f541a36 100644
> --- a/drivers/media/dvb-core/dvb_frontend.c
> +++ b/drivers/media/dvb-core/dvb_frontend.c
> @@ -1766,13 +1766,6 @@ static int dtv_property_process_set(struct dvb_frontend *fe,
> int r = 0;
> struct dtv_frontend_properties *c = &fe->dtv_property_cache;
>
> - /* Allow the frontend to validate incoming properties */
> - if (fe->ops.set_property) {
> - r = fe->ops.set_property(fe, tvp);
> - if (r < 0)
> - return r;
> - }
> -
> dtv_property_dump(fe, true, tvp);
>
> switch(tvp->cmd) {
> diff --git a/drivers/media/dvb-core/dvb_frontend.h b/drivers/media/dvb-core/dvb_frontend.h
> index 4d05846f2c1c..a50f8216ab76 100644
> --- a/drivers/media/dvb-core/dvb_frontend.h
> +++ b/drivers/media/dvb-core/dvb_frontend.h
> @@ -401,8 +401,6 @@ struct dtv_frontend_properties;
> * @search: callback function used on some custom algo search algos.
> * @tuner_ops: pointer to struct dvb_tuner_ops
> * @analog_ops: pointer to struct analog_demod_ops
> - * @set_property: callback function to allow the frontend to validade
> - * incoming properties. Should not be used on new drivers.
> */
> struct dvb_frontend_ops {
Hmm... actually, the patch is missing the removal of set_property().
The enclosed one should fix it.
Regards,
Mauro
---
[PATCH] media: dvb_frontend: get rid of set_property() callback
Now that all clients of set_property() were removed, get rid
of this callback.
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
diff --git a/drivers/media/dvb-core/dvb_frontend.c b/drivers/media/dvb-core/dvb_frontend.c
index 5d00e46d9432..8abe4f541a36 100644
--- a/drivers/media/dvb-core/dvb_frontend.c
+++ b/drivers/media/dvb-core/dvb_frontend.c
@@ -1766,13 +1766,6 @@ static int dtv_property_process_set(struct dvb_frontend *fe,
int r = 0;
struct dtv_frontend_properties *c = &fe->dtv_property_cache;
- /* Allow the frontend to validate incoming properties */
- if (fe->ops.set_property) {
- r = fe->ops.set_property(fe, tvp);
- if (r < 0)
- return r;
- }
-
dtv_property_dump(fe, true, tvp);
switch(tvp->cmd) {
diff --git a/drivers/media/dvb-core/dvb_frontend.h b/drivers/media/dvb-core/dvb_frontend.h
index 4d05846f2c1c..852b91ba49d2 100644
--- a/drivers/media/dvb-core/dvb_frontend.h
+++ b/drivers/media/dvb-core/dvb_frontend.h
@@ -401,11 +401,8 @@ struct dtv_frontend_properties;
* @search: callback function used on some custom algo search algos.
* @tuner_ops: pointer to struct dvb_tuner_ops
* @analog_ops: pointer to struct analog_demod_ops
- * @set_property: callback function to allow the frontend to validade
- * incoming properties. Should not be used on new drivers.
*/
struct dvb_frontend_ops {
-
struct dvb_frontend_info info;
u8 delsys[MAX_DELSYS];
@@ -464,8 +461,6 @@ struct dvb_frontend_ops {
struct dvb_tuner_ops tuner_ops;
struct analog_demod_ops analog_ops;
-
- int (*set_property)(struct dvb_frontend* fe, struct dtv_property* tvp);
};
#ifdef __DVB_CORE__
prev parent reply other threads:[~2017-09-15 10:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-15 9:10 [PATCH 1/5] media: stv0288: get rid of set_property boilerplate Mauro Carvalho Chehab
2017-09-15 9:10 ` [PATCH 2/5] media: stv6110: get rid of a srate dead code Mauro Carvalho Chehab
2017-09-15 9:30 ` Honza Petrouš
2017-09-15 9:46 ` Mauro Carvalho Chehab
2017-09-15 9:10 ` [PATCH 3/5] media: friio-fe: get rid of set_property() Mauro Carvalho Chehab
2017-09-15 9:11 ` [PATCH 4/5] media: dvb_frontend: get rid of get_property() callback Mauro Carvalho Chehab
2017-09-15 9:11 ` [PATCH 5/5] media: dvb_frontend: get rid of set_property() callback Mauro Carvalho Chehab
2017-09-15 10:05 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170915070554.52b6f145@vento.lan \
--to=mchehab@s-opensource.com \
--cc=colin.king@canonical.com \
--cc=linux-media@vger.kernel.org \
--cc=max.kellermann@gmail.com \
--cc=mchehab@infradead.org \
--cc=mingo@kernel.org \
--cc=mkrufky@linuxtv.org \
--cc=sakari.ailus@linux.intel.com \
--cc=shuah@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.