From: David Gibson <david@gibson.dropbear.id.au>
To: ccan@lists.ozlabs.org
Subject: Re: bitmap/tal again
Date: Fri, 15 Sep 2017 18:32:25 +1000 [thread overview]
Message-ID: <20170915083225.GL5250@umbus.fritz.box> (raw)
In-Reply-To: <20170915080355.zc3ohlzeho5lkcsp@matica.foolinux.mooo.com>
[-- Attachment #1.1: Type: text/plain, Size: 1394 bytes --]
On Fri, Sep 15, 2017 at 01:03:55AM -0700, Ian Zimmerman wrote:
> Hi, so I'd like to add the bitmap/tal submodule as discussed here:
>
> https://github.com/rustyrussell/ccan/pull/60
>
> but I'm not familiar enough with ccan dependency declarations yet :(
>
> 1. Should the dependency on tal be declared in bitmap/_info or in
> bitmap/tal/_info? The latter seems more natural, but for some reason
> the final pull request on github shows the former. I don't know if
> that's something I did and Rusty didn't correct, or something that Rusty
> did. (I also don't quite understand github, ARGH!)
In bitmap/tal/_info, definitely. Putting it in bitmap/_info will
change the dependencies of the base bitmap module, not your new
submodule.
> 2. Does bitmap/tal need to declare dependency on bitmap, or is that
> automatic? Or maybe the other way? I tried to look at other submodules
> in the tree, but there are only a few and none that quite match the
> relationship between this proposed pair.
Looking at ccan/tal/str, looks like the surrounding module should be
explicitly listed in dependencies.
>
> Well, if I know these 2 things it should get me started.
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
ccan mailing list
ccan@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/ccan
next prev parent reply other threads:[~2017-09-15 8:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-15 8:03 bitmap/tal again Ian Zimmerman
2017-09-15 8:32 ` David Gibson [this message]
2017-09-16 3:38 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170915083225.GL5250@umbus.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=ccan@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.