All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: qemu-devel@nongnu.org
Cc: borntraeger@de.ibm.com, agraf@suse.de, thuth@redhat.com,
	david@redhat.com, pmorel@linux.vnet.ibm.com,
	zyimin@linux.vnet.ibm.com, pasic@linux.vnet.ibm.com,
	Cornelia Huck <cohuck@redhat.com>
Subject: [Qemu-devel] [PATCH RFC 0/1] s390x: pci compat handling
Date: Fri, 15 Sep 2017 12:14:05 +0200	[thread overview]
Message-ID: <20170915101406.27823-1-cohuck@redhat.com> (raw)

While playing around with compat machines a bit, I noticed that my
zpci detanglement patches broke migration from 2.7 to current master
(2.8 or newer are fine, which is why I did not notice that before.)

qemu 2.7 seems to create a savevm that a s390-next (or master) build
without the s390 phb chokes on:

qemu-system-s390x: Unknown savevm section or instance 'PCIBUS' 0

Creating the s390 phb for compat machines seems to cure this; still
RFC for the following reasons:

- I'm not sure what we're supposed to do on builds without pci. Fail
  creating the compat machines? Do we need a new set of _NOPCI compat
  machines for that?
- I don't understand why 2.7 fails, but 2.8 and later are fine. At
  least, I was not able to spot which commit changed the behaviour
  here... and I really want to understand this. Pointers welcome.
- I have not tested it extensively yet.

Patch is against s390-next.

Cornelia Huck (1):
  s390x/ccw: create s390 phb for compat reasons as well

 hw/s390x/s390-virtio-ccw.c         | 6 +++++-
 include/hw/s390x/s390-virtio-ccw.h | 1 +
 2 files changed, 6 insertions(+), 1 deletion(-)

-- 
2.13.5

             reply	other threads:[~2017-09-15 10:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-15 10:14 Cornelia Huck [this message]
2017-09-15 10:14 ` [Qemu-devel] [PATCH RFC 1/1] s390x/ccw: create s390 phb for compat reasons as well Cornelia Huck
2017-09-15 11:57   ` David Hildenbrand
2017-09-15 13:07     ` Cornelia Huck
2017-09-15 13:09       ` David Hildenbrand
2017-09-15 13:22         ` Cornelia Huck
2017-09-15 13:37           ` David Hildenbrand
2017-09-15 14:16             ` Halil Pasic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170915101406.27823-1-cohuck@redhat.com \
    --to=cohuck@redhat.com \
    --cc=agraf@suse.de \
    --cc=borntraeger@de.ibm.com \
    --cc=david@redhat.com \
    --cc=pasic@linux.vnet.ibm.com \
    --cc=pmorel@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    --cc=zyimin@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.