From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@lst.de>,
James Bottomley <james.bottomley@hansenpartnership.com>,
linux-scsi@vger.kernel.org,
Alexander Potapenko <glider@google.com>,
Ingo Molnar <mingo@redhat.com>,
Dmitry Vyukov <dvyukov@google.com>,
security@kernel.org, Hannes Reinecke <hare@suse.com>
Subject: Re: [PATCH 2/2] sg: fixup infoleak when using SG_GET_REQUEST_TABLE
Date: Fri, 15 Sep 2017 19:54:55 +0200 [thread overview]
Message-ID: <20170915175455.GB8805@lst.de> (raw)
In-Reply-To: <1505477116-75013-3-git-send-email-hare@suse.de>
On Fri, Sep 15, 2017 at 02:05:16PM +0200, Hannes Reinecke wrote:
> When calling SG_GET_REQUEST_TABLE ioctl that only a half-filled
> table is returned; the remaining part will then contain stale
> kernel memory information.
> This patch zeroes out the entire table to avoid this issue.
>
> Signed-off-by: Hannes Reinecke <hare@suse.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2017-09-15 17:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-15 12:05 [PATCH 0/2] sg: fix infoleak when using SG_GET_REQUEST_TABLE Hannes Reinecke
2017-09-15 12:05 ` [PATCH 1/2] sg: factor out sg_fill_request_table() Hannes Reinecke
2017-09-15 14:26 ` Bart Van Assche
2017-09-15 17:54 ` Christoph Hellwig
2017-09-15 19:24 ` Martin K. Petersen
2017-09-15 19:44 ` Douglas Gilbert
2017-09-15 12:05 ` [PATCH 2/2] sg: fixup infoleak when using SG_GET_REQUEST_TABLE Hannes Reinecke
2017-09-15 14:29 ` Bart Van Assche
2017-09-15 17:54 ` Christoph Hellwig [this message]
2017-09-15 18:03 ` Eric Dumazet
2017-09-15 18:49 ` Linus Torvalds
2017-09-15 19:24 ` Martin K. Petersen
2017-09-15 19:44 ` Douglas Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170915175455.GB8805@lst.de \
--to=hch@lst.de \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=hare@suse.com \
--cc=hare@suse.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mingo@redhat.com \
--cc=security@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.