From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Andi Kleen <andi@firstfloor.org>,
linux-kernel@vger.kernel.org, jolsa@kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] perf, tools: Improve error messages for missing PMUs
Date: Fri, 15 Sep 2017 16:00:24 -0300 [thread overview]
Message-ID: <20170915190024.GD14469@kernel.org> (raw)
In-Reply-To: <20170915184510.GB31734@krava>
Em Fri, Sep 15, 2017 at 08:45:10PM +0200, Jiri Olsa escreveu:
> On Wed, Sep 13, 2017 at 02:50:06PM -0700, Andi Kleen wrote:
> > +++ b/tools/perf/util/metricgroup.c
> > @@ -477,7 +477,7 @@ int metricgroup__parse_groups(const struct option *opt,
> > memset(&parse_error, 0, sizeof(struct parse_events_error));
> > ret = parse_events(perf_evlist, extra_events.buf, &parse_error);
> > if (ret) {
> > - pr_err("Cannot set up events %s\n", extra_events.buf);
> > + parse_events_print_error(&parse_error, extra_events.buf);
>
> nit, mixed tabs/spaces indent, other than that:
Fixed that.
> Acked-by: Jiri Olsa <jolsa@kernel.org>
Thanks, applied.
- Arnaldo
next prev parent reply other threads:[~2017-09-15 19:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-13 21:50 [PATCH] perf, tools: Improve error messages for missing PMUs Andi Kleen
2017-09-15 18:45 ` Jiri Olsa
2017-09-15 19:00 ` Arnaldo Carvalho de Melo [this message]
2017-09-22 16:43 ` [tip:perf/core] perf pmu: " tip-bot for Andi Kleen
-- strict thread matches above, loose matches on Subject: below --
2017-09-12 0:26 [PATCH] perf, tools: " Andi Kleen
2017-09-13 13:34 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170915190024.GD14469@kernel.org \
--to=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.