From mboxrd@z Thu Jan 1 00:00:00 1970 From: Serge Semin Subject: Re: [PATCH 1/5] usb: usb251xb: Add USB2517/i hub support Date: Sat, 16 Sep 2017 02:55:50 +0300 Message-ID: <20170915235550.GB21291@mobilestation> References: <20170915233113.17855-1-fancer.lancer@gmail.com> <20170915233113.17855-2-fancer.lancer@gmail.com> <20170915234514.GA8407@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20170915234514.GA8407-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Greg KH Cc: richard.leitner-WcANXNA0UjBBDgjK7y7TUQ@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, Sergey.Semin-vHJ8rsvMqnUPfZBKTuL5GA@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Fri, Sep 15, 2017 at 04:45:14PM -0700, Greg KH wrote: > On Sat, Sep 16, 2017 at 02:31:09AM +0300, Serge Semin wrote: > > USB2517i hubs are very like USB251xb devices series. They have almost > > the same configuration registers space except number of ports, led > > configurations and lack of battery settings. All these peculiarities > > are reflected in this patch. > > Please add one type of feature at a time per patch. That makes it > easier to review and ensure you got it right. > > thanks, > > greg k-h Ok. The patch isn't that big though. Regards, -Sergey -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751539AbdIOXzs (ORCPT ); Fri, 15 Sep 2017 19:55:48 -0400 Received: from mail-lf0-f68.google.com ([209.85.215.68]:34011 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751184AbdIOXzp (ORCPT ); Fri, 15 Sep 2017 19:55:45 -0400 X-Google-Smtp-Source: AOwi7QAtpCGJ61PEKGkd7XYC/6W4mRLjtZ4e6mJawo+F1Onni/3S1rS+dFYyeBQo8rSo3PK6INv5og== Date: Sat, 16 Sep 2017 02:55:50 +0300 From: Serge Semin To: Greg KH Cc: richard.leitner@skidata.com, robh+dt@kernel.org, mark.rutland@arm.com, Sergey.Semin@t-platforms.ru, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] usb: usb251xb: Add USB2517/i hub support Message-ID: <20170915235550.GB21291@mobilestation> References: <20170915233113.17855-1-fancer.lancer@gmail.com> <20170915233113.17855-2-fancer.lancer@gmail.com> <20170915234514.GA8407@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170915234514.GA8407@kroah.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 15, 2017 at 04:45:14PM -0700, Greg KH wrote: > On Sat, Sep 16, 2017 at 02:31:09AM +0300, Serge Semin wrote: > > USB2517i hubs are very like USB251xb devices series. They have almost > > the same configuration registers space except number of ports, led > > configurations and lack of battery settings. All these peculiarities > > are reflected in this patch. > > Please add one type of feature at a time per patch. That makes it > easier to review and ensure you got it right. > > thanks, > > greg k-h Ok. The patch isn't that big though. Regards, -Sergey