From: Christoph Hellwig <hch@lst.de>
To: Brian Foster <bfoster@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 12/18] xfs: refactor xfs_bmap_add_extent_delay_real
Date: Sun, 17 Sep 2017 23:22:47 +0200 [thread overview]
Message-ID: <20170917212247.GA28851@lst.de> (raw)
In-Reply-To: <20170915170022.GC7276@bfoster.bfoster>
On Fri, Sep 15, 2017 at 01:00:22PM -0400, Brian Foster wrote:
> > - da_new = temp + temp2;
> > + da_new = PREV.br_blockcount + RIGHT.br_blockcount;
>
> da_new should be the new total indirect reservation. The above sets it
> to the total/remaining delalloc block count. E.g., it should probably be
> something like this:
>
> da_new = startblockval(PREV.br_startblock) +
> startblockval(RIGHT.br_startblock);
>
> Or alternatively you could set da_new right before diff is calculated
> and reuse it in that calculation. Otherwise the patch looks good.
Indeed. And we should probably use da_new for the calculation of
diff as well, or rather clean up the mess with the double
xfs_mod_fdblocks.
xfs_bmap_add_extent_delay_real is such a beast..
next prev parent reply other threads:[~2017-09-17 21:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-15 14:54 refactor extent manipulation V2 Christoph Hellwig
2017-09-15 14:54 ` [PATCH 01/18] xfs: fix incorrect extent state in xfs_bmap_add_extent_unwritten_real Christoph Hellwig
2017-09-15 14:54 ` [PATCH 02/18] xfs: use xfs_iext_get_extent instead of open coding it Christoph Hellwig
2017-09-15 14:54 ` [PATCH 03/18] xfs: don't set XFS_BTCUR_BPRV_WASDEL in xfs_bunmapi Christoph Hellwig
2017-09-15 14:54 ` [PATCH 04/18] xfs: rename bno to end in __xfs_bunmapi Christoph Hellwig
2017-09-15 14:54 ` [PATCH 05/18] xfs: use xfs_bmap_del_extent_delay for the data fork as well Christoph Hellwig
2017-09-15 14:54 ` [PATCH 06/18] xfs: move some more code into xfs_bmap_del_extent_real Christoph Hellwig
2017-09-15 14:54 ` [PATCH 07/18] xfs: use correct state defines in xfs_bmap_del_extent_{cow,delay} Christoph Hellwig
2017-09-15 16:59 ` Brian Foster
2017-09-15 14:54 ` [PATCH 08/18] xfs: use the state defines in xfs_bmap_del_extent_real Christoph Hellwig
2017-09-15 16:59 ` Brian Foster
2017-09-15 14:54 ` [PATCH 09/18] xfs: refactor xfs_del_extent_real Christoph Hellwig
2017-09-15 14:54 ` [PATCH 10/18] xfs: refactor xfs_bmap_add_extent_hole_delay Christoph Hellwig
2017-09-15 14:54 ` [PATCH 11/18] xfs: refactor xfs_bmap_add_extent_hole_real Christoph Hellwig
2017-09-15 14:54 ` [PATCH 12/18] xfs: refactor xfs_bmap_add_extent_delay_real Christoph Hellwig
2017-09-15 17:00 ` Brian Foster
2017-09-17 21:22 ` Christoph Hellwig [this message]
2017-09-15 14:54 ` [PATCH 13/18] xfs: refactor xfs_bmap_add_extent_unwritten_real Christoph Hellwig
2017-09-15 14:54 ` [PATCH 14/18] xfs: pass a struct xfs_bmbt_irec to xfs_bmbt_update Christoph Hellwig
2017-09-15 14:54 ` [PATCH 15/18] xfs: pass a struct xfs_bmbt_irec to xfs_bmbt_lookup_eq Christoph Hellwig
2017-09-15 14:54 ` [PATCH 16/18] xfs: replace xfs_bmbt_lookup_ge with xfs_bmbt_lookup_first Christoph Hellwig
2017-09-15 14:54 ` [PATCH 17/18] xfs: remove all xfs_bmbt_set_* helpers except for xfs_bmbt_set_all Christoph Hellwig
2017-09-15 14:54 ` [PATCH 18/18] xfs: remove xfs_bmbt_get_state Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170917212247.GA28851@lst.de \
--to=hch@lst.de \
--cc=bfoster@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.