From: Fam Zheng <famz@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: ldoktor@redhat.com, ehabkost@redhat.com, stefanha@gmail.com,
Amador Pahim <apahim@redhat.com>,
armbru@redhat.com, qemu-devel@nongnu.org, crosa@redhat.com,
mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH v8 04/13] qemu.py: improve message on negative exit code
Date: Mon, 18 Sep 2017 15:03:07 +0800 [thread overview]
Message-ID: <20170918070307.GH15551@lemon.lan> (raw)
In-Reply-To: <20170918064439.GB31915@localhost.localdomain>
On Mon, 09/18 08:44, Kevin Wolf wrote:
> > > > > + self._qemu_full_args = (self._wrapper + [self._binary] +
> > > > > + self._base_args() + self._args)
> > > >
> > > > The parentheses seem superfluous. With those removed:
> > > >
> > > > Reviewed-by: Fam Zheng <famz@redhat.com>
> > >
> > > Congratulations, with this advice you just killed all Python-based
> > > qemu-iotests and filled up my inbox with CI failure messages. :-)
> >
> > Oops. Why doesn't python understand such multi line expressions
> > impllied by "+" just like in "[,]"?
>
> To be honest, I didn't know that either until now. But apparently the
> different kinds of brackets (including those around function arguments)
> are the only things that allow multiline expressions in Python.
Yes, and now I read that PEP recommends using brackets for multilines compared
to backslashes. I was totally wrong with this advice.
Fam
next prev parent reply other threads:[~2017-09-18 7:03 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-01 11:28 [Qemu-devel] [PATCH v8 00/13] scripts/qemu.py fixes and cleanups Amador Pahim
2017-09-01 11:28 ` [Qemu-devel] [PATCH v8 01/13] qemu.py: fix is_running() return before first launch() Amador Pahim
2017-09-05 2:57 ` Fam Zheng
2017-09-01 11:28 ` [Qemu-devel] [PATCH v8 02/13] qemu.py: avoid writing to stdout/stderr Amador Pahim
2017-09-05 2:59 ` Fam Zheng
2017-09-21 10:35 ` Kevin Wolf
2017-09-21 12:17 ` Eduardo Habkost
2017-09-01 11:28 ` [Qemu-devel] [PATCH v8 03/13] qemu.py: use os.path.null instead of /dev/null Amador Pahim
2017-09-01 11:39 ` Philippe Mathieu-Daudé
2017-09-05 2:59 ` Fam Zheng
2017-09-01 11:28 ` [Qemu-devel] [PATCH v8 04/13] qemu.py: improve message on negative exit code Amador Pahim
2017-09-05 3:02 ` Fam Zheng
2017-09-18 5:18 ` Kevin Wolf
2017-09-18 5:39 ` Fam Zheng
2017-09-18 6:44 ` Kevin Wolf
2017-09-18 7:03 ` Fam Zheng [this message]
2017-09-01 11:28 ` [Qemu-devel] [PATCH v8 05/13] qemu.py: include debug information on launch error Amador Pahim
2017-09-05 3:05 ` Fam Zheng
2017-09-01 11:28 ` [Qemu-devel] [PATCH v8 06/13] qemu.py: make sure we only remove files we create Amador Pahim
2017-09-05 3:18 ` Fam Zheng
2017-09-14 19:38 ` Amador Pahim
2017-09-14 19:46 ` Eduardo Habkost
2017-09-14 20:05 ` Amador Pahim
2017-09-14 20:18 ` Eduardo Habkost
2017-09-14 20:21 ` Amador Pahim
2017-09-01 11:28 ` [Qemu-devel] [PATCH v8 07/13] qemu.py: close _qemu_log_path on cleanup Amador Pahim
2017-09-05 3:05 ` Fam Zheng
2017-09-01 11:28 ` [Qemu-devel] [PATCH v8 08/13] qemu.py: refactor launch() Amador Pahim
2017-09-05 3:06 ` Fam Zheng
2017-09-01 11:28 ` [Qemu-devel] [PATCH v8 09/13] qemu.py: always cleanup on shutdown() Amador Pahim
2017-09-05 3:07 ` Fam Zheng
2017-09-01 11:28 ` [Qemu-devel] [PATCH v8 10/13] qemu.py: use poll() instead of 'returncode' Amador Pahim
2017-09-05 3:07 ` Fam Zheng
2017-09-01 11:28 ` [Qemu-devel] [PATCH v8 11/13] qemu.py: cleanup redundant calls in launch() Amador Pahim
2017-09-05 3:20 ` Fam Zheng
2017-09-01 11:28 ` [Qemu-devel] [PATCH v8 12/13] qemu.py: launch vm only if it's not running Amador Pahim
2017-09-05 3:19 ` Fam Zheng
2017-09-01 11:28 ` [Qemu-devel] [PATCH v8 13/13] qemu.py: don't launch again before shutdown() Amador Pahim
2017-09-05 3:22 ` Fam Zheng
2017-09-05 10:02 ` [Qemu-devel] [PATCH v8 00/13] scripts/qemu.py fixes and cleanups Stefan Hajnoczi
2017-09-14 19:31 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170918070307.GH15551@lemon.lan \
--to=famz@redhat.com \
--cc=apahim@redhat.com \
--cc=armbru@redhat.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kwolf@redhat.com \
--cc=ldoktor@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.