Re: [PATCH] Staging: Dgnc: Remove unnecessary comments around control statements.

[Greg KH <gregkh@linuxfoundation.org>]

On Fri, Sep 15, 2017 at 09:14:34PM +0530, Keerthi Reddy wrote:
> Remove Un necessary comments around control statements

"comments"?  That's not what this patch does at all :(

> 
> Checked with checkpatch.pl.
> 
> With this changes, I am also able to compile the code.

That should always be the case, no need to ever say that :)

> 
> Signed-off-by: Keerthi Reddy <keerthigd4990@gmail.com>
> ---
>  drivers/staging/dgnc/dgnc_cls.c | 16 ++++++++--------
>  drivers/staging/dgnc/dgnc_neo.c | 22 +++++++++++-----------
>  drivers/staging/dgnc/dgnc_tty.c | 34 +++++++++++++++++-----------------
>  3 files changed, 36 insertions(+), 36 deletions(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c
> index 9639035..870ae3d 100644
> --- a/drivers/staging/dgnc/dgnc_cls.c
> +++ b/drivers/staging/dgnc/dgnc_cls.c
> @@ -706,7 +706,7 @@ static void cls_param(struct tty_struct *tty)
>  		 * unit is NOT open
>  		 */
>  		if (!(ch->ch_tun.un_flags & UN_ISOPEN) &&
> -		    (un->un_type == DGNC_PRINT))
> +		    un->un_type == DGNC_PRINT)
>  			baud = C_BAUD(ch->ch_pun.un_tty) & 0xff;
>  		else
>  			baud = C_BAUD(ch->ch_tun.un_tty) & 0xff;
> @@ -719,8 +719,8 @@ static void cls_param(struct tty_struct *tty)
>  
>  		jindex = baud;
>  
> -		if ((iindex >= 0) && (iindex < 4) && (jindex >= 0) &&
> -		    (jindex < 16)) {
> +		if (iindex >= 0 && iindex < 4 && jindex >= 0 &&
> +		    jindex < 16) {

This is harder to read now, don't you think?  And yes, it might be
"correct", but it is good to keep () around things like this so you
don't have to go look up the order-of-operations to ensure that the
developer got it correct.

thanks,

greg k-h