Re: [Outreachy kernel] [PATCH] Staging: irda: drivers: Replace (skb == NULL) with (!skb)

[Greg KH <greg@kroah.com>]

On Fri, Sep 15, 2017 at 12:42:42PM +0200, Julia Lawall wrote:
> 
> 
> On Fri, 15 Sep 2017, Meghana Madhyastha wrote:
> 
> > Some functions return NULL as an indication of failure.
> > The style (!skb) is more common than (skb == NULL) for these
> > functions.
> >
> > Found by the following Coccinelle script.
> >
> > @@
> > identifier i;
> > statement S;
> > @@
> >
> > i = (\(kmalloc\|devm_kzalloc\|kmalloc_array\|devm_ioremap\|usb_alloc_urb\|
> > alloc_netdev\|dev_alloc_skb\)(...));
> >
> > (
> > -if (i == NULL)
> > +if (!i)
> > S
> 
> If you provide just this option, Coccinelle should expand your rule to
> consider the other option as well.
> 
> You can see the section on isomorphisms in the Coccinelle tutorial.
> 
> > |
> > -if (NULL == i)
> > +if (!i)
> > S
> > )
> >
> > Signed-off-by: Meghana Madhyastha <meghana.madhyastha@gmail.com>
> 
> Acked-by: drivers/staging/irda/drivers/ali-ircc.c

Odd acked-by signature :)