Re: [Qemu-devel] [PATCH v3] s390x/ccw: create s390 phb for compat reasons as well

[Cornelia Huck <cohuck@redhat.com>]

On Mon, 18 Sep 2017 10:58:47 +0200
Christian Borntraeger <borntraeger@de.ibm.com> wrote:

> On 09/18/2017 10:55 AM, Cornelia Huck wrote:
> > d32bd032d8 ("s390x/ccw: create s390 phb conditionally") made
> > registering the s390 pci host bridge conditional on presense
> > of the zpci facility bit. Sadly, that breaks migration from
> > machines that did not use the cpu model (2.7 and previous).
> > 
> > Create the s390 phb for pre-cpu model machines as well: We can
> > tweak s390_has_feat() to always indicate the zpci facility bit
> > when no cpu model is available (on 2.7 and previous compat machines).  
> 
> Looks better now. Thanks
> > 
> > Fixes: d32bd032d8 ("s390x/ccw: create s390 phb conditionally")
> > Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
> > Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> > ---
> > 
> > v2->v3:
> > - no longer RFC (I tested a bit more)
> > - removed unrelated hunk
> > - more verbose patch description
> > 
> > I'll wait a bit for more acks/reviews and will probably send a pull
> > request for s390x tomorrow or so before the amount of queued patches
> > gets out of hand...  
> 
> I have a small amount of patches pending, but then I got sick last week
> so I still have to sort out things. Lets do the pull request and we can
> then queue the other patches after they have received proper review.

Sounds like a plan.