Re: [Qemu-devel] [PATCH v3 2/2] virtio-gpu-ccw: Create a virtio gpu device for the ccw bus

[Cornelia Huck <cohuck@redhat.com>]

On Fri, 15 Sep 2017 10:40:32 -0400
Farhan Ali <alifm@linux.vnet.ibm.com> wrote:

> Wire up the virtio-gpu device for the CCW bus. The virtio-gpu
> is a virtio-1 device, so disable revision 0.
> 
> Signed-off-by: Farhan Ali <alifm@linux.vnet.ibm.com>
> Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
> Reviewed-by: Halil Pasic <pasic@linux.vnet.ibm.com>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> ---
>  hw/s390x/virtio-ccw.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++
>  hw/s390x/virtio-ccw.h | 10 ++++++++++
>  2 files changed, 59 insertions(+)
> 
> diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c
> index b1976fd..12cacf6 100644
> --- a/hw/s390x/virtio-ccw.c
> +++ b/hw/s390x/virtio-ccw.c

> @@ -1815,6 +1863,7 @@ static void virtio_ccw_register(void)
>      type_register_static(&vhost_vsock_ccw_info);
>  #endif
>      type_register_static(&virtio_ccw_crypto);
> +    type_register_static(&virtio_ccw_gpu);

Not a critique of this patch, just an observation: For virtio-ccw, we
tend to collect the various virtio devices all in the same file. For
virtio-pci, they sometimes get separate files. Not sure which is
better, but it means that sometimes only the virtio-pci version is
added...

>  }
>  
>  type_init(virtio_ccw_register)

The patch looks good to me.

Gerd, if the first patch looks good to you, I can take both patches
through the s390 tree. If you prefer to merge the patches yourself,
that's fine with me as well.

Reviewed-by: Cornelia Huck <cohuck@redhat.com>