All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: srinivas.kandagatla@linaro.org
Cc: linux-kernel@vger.kernel.org,
	Masahiro Yamada <yamada.masahiro@socionext.com>
Subject: Re: [PATCH 3/4] nvmem: remove inline in drivers/nvmem/core.c
Date: Mon, 18 Sep 2017 16:09:34 +0200	[thread overview]
Message-ID: <20170918140934.GA2512@kroah.com> (raw)
In-Reply-To: <20170911090014.16806-4-srinivas.kandagatla@linaro.org>

On Mon, Sep 11, 2017 at 11:00:13AM +0200, srinivas.kandagatla@linaro.org wrote:
> From: Masahiro Yamada <yamada.masahiro@socionext.com>
> 
> These two functions are defined in .c file, but called just once
> (at least for now).  So, the compiler will fold them into their
> callers even without the "inline" markers.
> 
> However, this kind of optimization should not be done by hand.
> It is compiler's judge after all.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
>  drivers/nvmem/core.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)

This isn't really a bugfix, so should wait for 4.15-rc1.

thanks,

greg k-h

  reply	other threads:[~2017-09-18 14:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-11  9:00 [PATCH 0/4] nvmem: set2 patches for v4.14 srinivas.kandagatla
     [not found] ` <20170911090014.16806-1-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-09-11  9:00   ` [PATCH 1/4] nvmem: core: return EFBIG on out-of-range write srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A
2017-09-11  9:00     ` srinivas.kandagatla
2017-09-11  9:00 ` [PATCH 2/4] nvmem: add missing of_node_put() in of_nvmem_cell_get() srinivas.kandagatla
2017-09-11  9:00 ` [PATCH 3/4] nvmem: remove inline in drivers/nvmem/core.c srinivas.kandagatla
2017-09-18 14:09   ` Greg Kroah-Hartman [this message]
2017-09-18 15:02     ` Srinivas Kandagatla
2017-09-11  9:00 ` [PATCH 4/4] nvmem: remove unneeded IS_ENABLED(CONFIG_NVMEM) conditional srinivas.kandagatla
2017-09-18 14:09   ` Greg Kroah-Hartman
2017-09-18 15:02     ` Srinivas Kandagatla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170918140934.GA2512@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.