From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Jean Delvare <jdelvare@suse.de>
Cc: linux-s390@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>
Subject: Re: [PATCH v2] s390/char: Fix cdev_add usage
Date: Mon, 18 Sep 2017 16:22:40 +0200 [thread overview]
Message-ID: <20170918142240.GF4649@osiris> (raw)
In-Reply-To: <20170918111313.1fc7126e@endymion>
On Mon, Sep 18, 2017 at 11:13:13AM +0200, Jean Delvare wrote:
> Function cdev_add does set cdev->dev, so there is no point in setting
> it prior to calling this function.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
> Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
> ---
> Untested. Changes since v1 (2016-07-13):
> * Improved description
> * Added a few blank lines to make the code more readable
>
> drivers/s390/char/tape_class.c | 3 +--
> drivers/s390/char/vmlogrdr.c | 4 ++--
> drivers/s390/char/vmur.c | 4 ++--
> 3 files changed, 5 insertions(+), 6 deletions(-)
Applied, however without the extra blank lines ;)
Thanks!
prev parent reply other threads:[~2017-09-18 14:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-18 9:13 [PATCH v2] s390/char: Fix cdev_add usage Jean Delvare
2017-09-18 14:22 ` Heiko Carstens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170918142240.GF4649@osiris \
--to=heiko.carstens@de.ibm.com \
--cc=jdelvare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.