From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: Unset legacy_cursor_update early in intel_atomic_commit, v2. Date: Mon, 18 Sep 2017 18:03:12 +0300 Message-ID: <20170918150312.GC4914@intel.com> References: <20170918101250.6076-1-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0263F6E39F for ; Mon, 18 Sep 2017 15:03:20 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20170918101250.6076-1-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBTZXAgMTgsIDIwMTcgYXQgMTI6MTI6NTBQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gQ29tbWl0IGI0NGQ1YzBjMTA1YSAoImRybS9pOTE1OiBBbHdheXMgd2FpdCBm b3IgZmxpcF9kb25lLCB2Mi4iKSByZW1vdmVkCj4gdGhlIGNhbGwgdG8gd2FpdF9mb3JfdmJsYW5r cyBhbmQgcmVwbGFjZWQgaXQgd2l0aCBmbGlwX2RvbmUuCj4gCj4gVW5mb3J0dW5hdGVseSBsZWdh Y3lfY3Vyc29yX3VwZGF0ZSB3YXMgdW5zZXQgdG9vIGxhdGUsIGFuZCB0aGUKPiByZXBsYWNlbWVu dCBjYWxsIGRybV9hdG9taWNfaGVscGVyX3dhaXRfZm9yX2ZsaXBfZG9uZSgpIHdhcwo+IGEgbm9v cC4gTWFrZSBzdXJlIHRoYXQgaXRzIHVuc2V0IGJlZm9yZSBzZXR1cF9jb21taXQoKSBpcwo+IGNh bGxlZCB0byBmaXggdGhpcyBpc3N1ZS4KPiAKPiBDaGFuZ2VzIHNpbmNlIHYxOgo+IC0gRm9yY2Ug dmJsYW5rIHdhaXQgZm9yIHdhdGVybWFya3Mgbm90IHlldCBjb252ZXJ0ZWQgdG8gYXRvbWljIHRv by4gKFZpbGxlKQo+IC0gVXNlIGZvcl9lYWNoX25ld19pbnRlbF9jcnRjX2luX3N0YXRlLiAoVmls bGUpCj4gCj4gU2lnbmVkLW9mZi1ieTogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hv cnN0QGxpbnV4LmludGVsLmNvbT4KPiBGaXhlczogYjQ0ZDVjMGMxMDVhICgiZHJtL2k5MTU6IEFs d2F5cyB3YWl0IGZvciBmbGlwX2RvbmUsIHYyLiIpCj4gQnVnemlsbGE6IGh0dHBzOi8vYnVncy5m cmVlZGVza3RvcC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjY3NQo+IFRlc3RjYXNlOiBrbXNfY3Vy c29yX2NyYwo+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+IENj OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAbGludXguaW50ZWwuY29tPgo+IFJlcG9ydGVkLWJ5 OiBNYXJ0YSBMw7Zmc3RlZHQgPG1hcnRhLmxvZnN0ZWR0QGludGVsLmNvbT4KPiBDYzogTWFydGEg TMO2ZnN0ZWR0IDxtYXJ0YS5sb2ZzdGVkdEBpbnRlbC5jb20+Cj4gVGVzdGVkLWJ5OiBNYXJ0YSBM w7Zmc3RlZHQgPG1hcnRhLmxvZnN0ZWR0QGludGVsLmNvbT4KPiBDYzogVmlsbGUgU3lyasOkbMOk IDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZGlzcGxheS5jIHwgNDUgKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0t LS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAyNiBpbnNlcnRpb25zKCspLCAxOSBkZWxldGlvbnMo LSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5j IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gaW5kZXggODU5OWU0MjVh YmIxLi44ZDA1MTI1NmRhMWUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5j Cj4gQEAgLTEyNTE3LDIxICsxMjUxNywxMCBAQCBzdGF0aWMgaW50IGludGVsX2F0b21pY19jb21t aXQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk ZXZfcHJpdiA9IHRvX2k5MTUoZGV2KTsKPiAgCWludCByZXQgPSAwOwo+ICAKPiAtCXJldCA9IGRy bV9hdG9taWNfaGVscGVyX3NldHVwX2NvbW1pdChzdGF0ZSwgbm9uYmxvY2spOwo+IC0JaWYgKHJl dCkKPiAtCQlyZXR1cm4gcmV0Owo+IC0KPiAgCWRybV9hdG9taWNfc3RhdGVfZ2V0KHN0YXRlKTsK PiAgCWk5MTVfc3dfZmVuY2VfaW5pdCgmaW50ZWxfc3RhdGUtPmNvbW1pdF9yZWFkeSwKPiAgCQkJ ICAgaW50ZWxfYXRvbWljX2NvbW1pdF9yZWFkeSk7Cj4gIAo+IC0JcmV0ID0gaW50ZWxfYXRvbWlj X3ByZXBhcmVfY29tbWl0KGRldiwgc3RhdGUpOwo+IC0JaWYgKHJldCkgewo+IC0JCURSTV9ERUJV R19BVE9NSUMoIlByZXBhcmluZyBzdGF0ZSBmYWlsZWQgd2l0aCAlaVxuIiwgcmV0KTsKPiAtCQlp OTE1X3N3X2ZlbmNlX2NvbW1pdCgmaW50ZWxfc3RhdGUtPmNvbW1pdF9yZWFkeSk7Cj4gLQkJcmV0 dXJuIHJldDsKPiAtCX0KPiAtCj4gIAkvKgo+ICAJICogVGhlIGludGVsX2xlZ2FjeV9jdXJzb3Jf dXBkYXRlKCkgZmFzdCBwYXRoIHRha2VzIGNhcmUKPiAgCSAqIG9mIGF2b2lkaW5nIHRoZSB2Ymxh bmsgd2FpdHMgZm9yIHNpbXBsZSBjdXJzb3IKPiBAQCAtMTI1NDAsMTkgKzEyNTI5LDM3IEBAIHN0 YXRpYyBpbnQgaW50ZWxfYXRvbWljX2NvbW1pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ICAJ ICogdXBkYXRlcyBoYXBwZW4gZHVyaW5nIHRoZSBjb3JyZWN0IGZyYW1lcy4gR2VuOSsgaGF2ZQo+ ICAJICogZG91YmxlIGJ1ZmZlcmVkIHdhdGVybWFya3MgYW5kIHNvIHNob3VsZG4ndCBuZWVkIHRo aXMuCj4gIAkgKgo+IC0JICogRG8gdGhpcyBhZnRlciBkcm1fYXRvbWljX2hlbHBlcl9zZXR1cF9j b21taXQoKSBhbmQKPiAtCSAqIGludGVsX2F0b21pY19wcmVwYXJlX2NvbW1pdCgpIGJlY2F1c2Ug d2Ugc3RpbGwgd2FudAo+IC0JICogdG8gc2tpcCB0aGUgZmxpcCBhbmQgZmIgY2xlYW51cCB3YWl0 cy4gQWx0aG91Z2ggdGhhdAo+IC0JICogZG9lcyByaXNrIHlhbmtpbmcgdGhlIG1hcHBpbmcgZnJv bSB1bmRlciB0aGUgZGlzcGxheQo+IC0JICogZW5naW5lLgo+ICsJICogVW5zZXQgc3RhdGUtPmxl Z2FjeV9jdXJzb3JfdXBkYXRlIGJlZm9yZSB0aGUgY2FsbCB0bwo+ICsJICogZHJtX2F0b21pY19o ZWxwZXJfc2V0dXBfY29tbWl0KCkgYmVjYXVzZSBvdGhlcndpc2UKPiArCSAqIGRybV9hdG9taWNf aGVscGVyX3dhaXRfZm9yX2ZsaXBfZG9uZSgpIGlzIGEgbm9vcCBhbmQKPiArCSAqIHdlIGdldCBG SUZPIHVuZGVycnVucyBiZWNhdXNlIHdlIGRpZG4ndCB3YWl0Cj4gKwkgKiBmb3IgdmJsYW5rLgo+ ICAJICoKPiAgCSAqIEZJWE1FIGRvaW5nIHdhdGVybWFya3MgYW5kIGZiIGNsZWFudXAgZnJvbSBh IHZibGFuayB3b3JrZXIKPiAgCSAqIChhc3N1bWluZyB3ZSBoYWQgYW55KSB3b3VsZCBzb2x2ZSB0 aGVzZSBwcm9ibGVtcy4KPiAgCSAqLwo+IC0JaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPCA5KQo+ IC0JCXN0YXRlLT5sZWdhY3lfY3Vyc29yX3VwZGF0ZSA9IGZhbHNlOwo+ICsJaWYgKElOVEVMX0dF TihkZXZfcHJpdikgPCA5ICYmIHN0YXRlLT5sZWdhY3lfY3Vyc29yX3VwZGF0ZSkgewo+ICsJCXN0 cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpuZXdfY3J0Y19zdGF0ZTsKPiArCQlzdHJ1Y3QgaW50ZWxf Y3J0YyAqY3J0YzsKPiArCQlpbnQgaTsKPiArCj4gKwkJZm9yX2VhY2hfbmV3X2ludGVsX2NydGNf aW5fc3RhdGUoaW50ZWxfc3RhdGUsIGNydGMsIG5ld19jcnRjX3N0YXRlLCBpKQo+ICsJCQlpZiAo bmV3X2NydGNfc3RhdGUtPndtLm5lZWRfcG9zdHZibF91cGRhdGUgfHwKPiArCQkJICAgIG5ld19j cnRjX3N0YXRlLT51cGRhdGVfd21fcG9zdCkKPiArCQkJCXN0YXRlLT5sZWdhY3lfY3Vyc29yX3Vw ZGF0ZSA9IGZhbHNlOwoKSG1tLiBJIGd1ZXNzIHRoYXQncyBiZXR0ZXIuIEJ1dCBJIHN0aWxsIGRv bid0IHNlZSB3aHkgeW91IHdhbnQgdG8gY2hhbmdlCnRoaXMgYml0IG9mIGNvZGUgaW4gdGhpcyBw YXRjaC4gQUZBSUNTIGl0J3MgZ290IG5vdGhpbmcgdG8gZG8gd2l0aCB0aGUgZml4Cml0c2VsZiwg YW5kIGluc3RlYWQgaXQncyBqdXN0IHRyeWluZyB0byBvcHRpbWl6ZSBzb21lIGN1cnNvciB1cGRh dGVzCnRoYXQgd2VyZSBraWNrZWQgb3ZlciB0byB0aGUgc2xvdyBwYXRoLiBPciBhbSBJIG1pc3Np bmcgc29tZXRoaW5nPwoKPiArCX0KPiArCj4gKwlyZXQgPSBpbnRlbF9hdG9taWNfcHJlcGFyZV9j b21taXQoZGV2LCBzdGF0ZSk7Cj4gKwlpZiAocmV0KSB7Cj4gKwkJRFJNX0RFQlVHX0FUT01JQygi UHJlcGFyaW5nIHN0YXRlIGZhaWxlZCB3aXRoICVpXG4iLCByZXQpOwo+ICsJCWk5MTVfc3dfZmVu Y2VfY29tbWl0KCZpbnRlbF9zdGF0ZS0+Y29tbWl0X3JlYWR5KTsKPiArCQlyZXR1cm4gcmV0Owo+ ICsJfQo+ICsKPiArCXJldCA9IGRybV9hdG9taWNfaGVscGVyX3NldHVwX2NvbW1pdChzdGF0ZSwg bm9uYmxvY2spOwo+ICsJaWYgKCFyZXQpCj4gKwkJcmV0ID0gZHJtX2F0b21pY19oZWxwZXJfc3dh cF9zdGF0ZShzdGF0ZSwgdHJ1ZSk7Cj4gIAo+IC0JcmV0ID0gZHJtX2F0b21pY19oZWxwZXJfc3dh cF9zdGF0ZShzdGF0ZSwgdHJ1ZSk7Cj4gIAlpZiAocmV0KSB7Cj4gIAkJaTkxNV9zd19mZW5jZV9j b21taXQoJmludGVsX3N0YXRlLT5jb21taXRfcmVhZHkpOwo+ICAKPiAtLSAKPiAyLjE0LjEKCi0t IApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2ludGVsLWdmeAo=