Re: [PATCH v2 1/2] iptables: support match info fixup after tc_init

[Pablo Neira Ayuso <pablo@netfilter.org>]

Hi Rafael,

On Sun, Sep 17, 2017 at 02:20:30PM +0300, Shmulik Ladkani wrote:
> From: Rafael Buchbinder <rafi@rbk.ms>
> 
> From: Rafael Buchbinder <rafi@rbk.ms>
> 
> This commit introduces a framework to fixup match info,
> which may be required by an extension.
> 
> Signed-off-by: Rafael Buchbinder <rafi@rbk.ms>
> Signed-off-by: Shmulik Ladkani <shmulik@nsof.io>
> ---
>  include/xtables.h    |  3 +++
>  iptables/ip6tables.c | 35 +++++++++++++++++++++++++++++++++++
>  iptables/iptables.c  | 34 ++++++++++++++++++++++++++++++++++
>  3 files changed, 72 insertions(+)
> 
> diff --git a/include/xtables.h b/include/xtables.h
> index e9bc3b7d..687cfe9f 100644
> --- a/include/xtables.h
> +++ b/include/xtables.h
> @@ -273,6 +273,9 @@ struct xtables_match {
>  	/* ip is struct ipt_ip * for example */
>  	void (*save)(const void *ip, const struct xt_entry_match *match);
>  
> +	/* Fixes the match info after init. */
> +	void (*tc_init_fixup)(struct xt_entry_match *match);

If this is only broken from tc ipt actions, could you fix this from
iproute2/tc instead?