From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH] nvme: allow timed-out ios to retry
Date: Mon, 18 Sep 2017 13:24:48 -0400 [thread overview]
Message-ID: <20170918172447.GC17096@localhost.localdomain> (raw)
In-Reply-To: <e2ccf8e7-7c58-4f8d-a8e2-c9e846090e8c@broadcom.com>
On Mon, Sep 18, 2017@10:15:45AM -0700, James Smart wrote:
>
> So where are we with this - what should be put in place ?
>
> The one revision I'd make from above based is - we'd only apply this timer
> on an I/O marked with a fastfail flag.
That's unnecessary as we already return 'false' immediately from the
blk_noretry_request check (which checks failfast) prior to checking the
timeout and retry count. So, I think you're patch is good as-is.
next prev parent reply other threads:[~2017-09-18 17:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-07 20:18 [PATCH] nvme: allow timed-out ios to retry James Smart
2017-09-07 20:37 ` Keith Busch
2017-09-08 16:11 ` James Smart
2017-09-18 17:15 ` James Smart
2017-09-18 17:24 ` Keith Busch [this message]
2017-09-18 17:42 ` James Smart
2017-09-18 17:49 ` Keith Busch
2017-09-18 0:27 ` Christoph Hellwig
2017-09-20 11:27 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170918172447.GC17096@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.