From mboxrd@z Thu Jan 1 00:00:00 1970 From: keith.busch@intel.com (Keith Busch) Date: Mon, 18 Sep 2017 13:49:03 -0400 Subject: [PATCH] nvme: allow timed-out ios to retry In-Reply-To: References: <20170907201804.24979-1-jsmart2021@gmail.com> <20170907203759.GA2832@localhost.localdomain> <20170918172447.GC17096@localhost.localdomain> Message-ID: <20170918174902.GE17096@localhost.localdomain> On Mon, Sep 18, 2017@10:42:00AM -0700, James Smart wrote: > On 9/18/2017 10:24 AM, Keith Busch wrote: > > On Mon, Sep 18, 2017@10:15:45AM -0700, James Smart wrote: > > > So where are we with this - what should be put in place ? > > > > > > The one revision I'd make from above based is - we'd only apply this timer > > > on an I/O marked with a fastfail flag. > > That's unnecessary as we already return 'false' immediately from the > > blk_noretry_request check (which checks failfast) prior to checking the > > timeout and retry count. So, I think you're patch is good as-is. > ok - how about a Reviewed-by ? I accidently sent directly to Christoph off-list. Reviewed-by: Keith Busch