From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH v2 3/5] xen/livepatch/ARM32: Don't load and crash on livepatches loaded with wrong alignment. Date: Mon, 18 Sep 2017 15:37:57 -0400 Message-ID: <20170918193757.GB32401@char.us.oracle.com> References: <20170726194756.20265-4-konrad@kernel.org> <597F36D60200007800103088@prv-mh.provo.novell.com> <20170731160437.GK9952@char.us.oracle.com> <59819945020000780010323D@prv-mh.provo.novell.com> <20170907173644.GA7717@localhost.localdomain> <59B27F3F0200007800178AC9@prv-mh.provo.novell.com> <20170909120529.GA19614@localhost.localdomain> <59B66CFB0200007800179708@prv-mh.provo.novell.com> <20170912002212.GB30969@localhost.localdomain> <59B7BD800200007800179DB3@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1duJk3-0001eZ-Ht for xen-devel@lists.xenproject.org; Tue, 19 Sep 2017 14:43:15 +0000 Content-Disposition: inline In-Reply-To: <59B7BD800200007800179DB3@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich Cc: julien.grall@arm.com, sstabellini@kernel.org, xen-devel@lists.xenproject.org, andrew.cooper3@citrix.com List-Id: xen-devel@lists.xenproject.org T24gVHVlLCBTZXAgMTIsIDIwMTcgYXQgMDI6NTc6MDRBTSAtMDYwMCwgSmFuIEJldWxpY2ggd3Jv dGU6Cj4gPj4+IE9uIDEyLjA5LjE3IGF0IDAyOjIyLCA8a29ucmFkQGtlcm5lbC5vcmc+IHdyb3Rl Ogo+ID4gT24gTW9uLCBTZXAgMTEsIDIwMTcgYXQgMDM6MDE6MTVBTSAtMDYwMCwgSmFuIEJldWxp Y2ggd3JvdGU6Cj4gPj4gSG1tLCBhcyBsb25nIGFzIHRoZSByZWxvY2F0aW9uIGlzbid0IHJlcXVp cmVkIHRvIGJlIGFnYWluc3QgYWxpZ25lZAo+ID4+IGZpZWxkcyBvbmx5IChtYW5kYXRlZCBieSB0 aGUgcHJvY2Vzc29yIEFCSSkgSSB0aGluayB0aGUgY29kZSBkb2luZwo+ID4+IHRoZSByZWxvY2F0 aW9ucyB3b3VsZCBpbnN0ZWFkIG5lZWQgdG8gc3BsaXQgdGhlIGFjY2VzcywgcmF0aGVyIHRoYW4K PiA+PiBjYWxsaW5nIHRoZSBzZWN0aW9uIG1pc2FsaWduZWQgb3IgaW5jcmVhc2luZyBhbGlnbm1l bnQgYmV5b25kIHdoYXQKPiA+PiB0aGUgRUxGIHNlY3Rpb24gaGVhZGVycyBzYXkuCj4gPiAKPiA+ IE1heWJlIHRoZSBzZXJpYWwgbG9nIHdvdWxkIGV4cGxhaW4gdGhpcyBiZXR0ZXI6Cj4gPiAKPiA+ IHhlbmRfY29uZmlnX2Zvcm1hdCAgICAgOiA0Cj4gPiBFeGVjdXRpbmc6ICcoc2V0IC1lO2NkIC9y b290L3Rlc3QvbGl2ZXBhdGNoO3hlbi1saXZlcGF0Y2ggbG9hZCAKPiA+IHhlbl9ieWVfd29ybGQu bGl2ZXBhdGNoKScgLi4oWEVOKSBsaXZlcGF0Y2guYzo0MTM6IGxpdmVwYXRjaDogeGVuX2J5ZV93 b3JsZDogTG9hZGVkIC5ub3RlLmdudS5idWlsZC1pZCBhdCAwMGEwODAwMAo+ID4gKFhFTikgbGl2 ZXBhdGNoLmM6NDEzOiBsaXZlcGF0Y2g6IHhlbl9ieWVfd29ybGQ6IExvYWRlZCAudGV4dCBhdCAw MGEwNjAwMAo+ID4gKFhFTikgbGl2ZXBhdGNoLmM6NDEzOiBsaXZlcGF0Y2g6IHhlbl9ieWVfd29y bGQ6IExvYWRlZCAucm9kYXRhIGF0IDAwYTA4MDI0Cj4gPiAoWEVOKSBsaXZlcGF0Y2guYzo0MTM6 IGxpdmVwYXRjaDogeGVuX2J5ZV93b3JsZDogTG9hZGVkIC5yb2RhdGEuc3RyMS40IGF0IDAwYTA4 MDM4Cj4gPiAoWEVOKSBsaXZlcGF0Y2guYzo0MTM6IGxpdmVwYXRjaDogeGVuX2J5ZV93b3JsZDog TG9hZGVkIC5saXZlcGF0Y2guZGVwZW5kcyBhdCAwMGEwODA0Mwo+ID5bLi4uXQo+ID4gS2VlcCBp biBtaW5kIHRoYXQgdGhpcyBvbmx5IGhhcHBlbnMgaWYgSSBjcm9zcy1jb21waWxlIEFSTTMyIHVu ZGVyIHg4Ni4KPiAKPiBUaGF0IHdvdWxkIHN1Z2dlc3QgYSBidWlsZCBlbnZpcm9ubWVudCAvIGJ1 aWxkIHRvb2xzIGlzc3VlIHRoZW46Cj4gQ3Jvc3MgYnVpbGRzIGFyZW4ndCBzdXBwb3NlZCB0byBw cm9kdWNlIGJpbmFyaWVzIGRpZmZlcmVudCBmcm9tCj4gbmF0aXZlIGJ1aWxkcy4KCkhtLCB0aGUg Z2NjIHBhcmFtZXRlcnMgb24gYm90aCBuYXRpdmUgYW5kIGNyb3NzIGNvbXBpbGVyIGhhdmUgc2Ft ZSBhcmdzOgoKa29ucmFkQG9zc3Rlc3Q6L3Nydi9jdWJpZXRydWNrL3NvdXJjZSQgZGlmZiBuYXRp dmUuaW52b2NhdGlvbiAvdG1wL2Nyb3NzLmludm9jYXRpb24gCjFjMQo8IGdjYyAtbWFybSAtREJV SUxEX0lEIC1mbm8tc3RyaWN0LWFsaWFzaW5nIC1zdGQ9Z251OTkgLVdhbGwgLVdzdHJpY3QtcHJv dG90eXBlcyAtV2RlY2xhcmF0aW9uLWFmdGVyLXN0YXRlbWVudCAtV25vLXVudXNlZC1idXQtc2V0 LXZhcmlhYmxlIC1Xbm8tdW51c2VkLWxvY2FsLXR5cGVkZWZzICAgLU8xIC1ub3N0ZGluYyAtZm5v LWJ1aWx0aW4gLWZuby1jb21tb24gLVdlcnJvciAtV3JlZHVuZGFudC1kZWNscyAtV25vLXBvaW50 ZXItYXJpdGggLXBpcGUgLWcgLURfX1hFTl9fIC1pbmNsdWRlIC9zb3VyY2UveGVuLm9yaWcuZ2l0 L3hlbi9pbmNsdWRlL3hlbi9jb25maWcuaCAnLURfX09CSkVDVF9GSUxFX189Inhlbl9ieWVfd29y bGQubyInIC1XYSwtLXN0cmlwLWxvY2FsLWFic29sdXRlIC1mbm8tb21pdC1mcmFtZS1wb2ludGVy IC1NTUQgLU1GIC4vLnhlbl9ieWVfd29ybGQuby5kIC1tc29mdC1mbG9hdCAtbWNwdT1jb3J0ZXgt YTE1IC1JL3NvdXJjZS94ZW4ub3JpZy5naXQveGVuL2luY2x1ZGUgLWZuby1zdGFjay1wcm90ZWN0 b3IgLWZuby1leGNlcHRpb25zIC1XbmVzdGVkLWV4dGVybnMgLURHQ0NfSEFTX1ZJU0lCSUxJVFlf QVRUUklCVVRFIC1tYXJtIC1EQlVJTERfSUQgLWZuby1zdHJpY3QtYWxpYXNpbmcgLXN0ZD1nbnU5 OSAtV2FsbCAtV3N0cmljdC1wcm90b3R5cGVzIC1XZGVjbGFyYXRpb24tYWZ0ZXItc3RhdGVtZW50 IC1Xbm8tdW51c2VkLWJ1dC1zZXQtdmFyaWFibGUgLVduby11bnVzZWQtbG9jYWwtdHlwZWRlZnMg ICAtYyB4ZW5fYnllX3dvcmxkLmMgLW8geGVuX2J5ZV93b3JsZC5vCi0tLQo+IGFybS1saW51eC1n bnUtZ2NjIC1tYXJtIC1EQlVJTERfSUQgLWZuby1zdHJpY3QtYWxpYXNpbmcgLXN0ZD1nbnU5OSAt V2FsbCAtV3N0cmljdC1wcm90b3R5cGVzIC1XZGVjbGFyYXRpb24tYWZ0ZXItc3RhdGVtZW50IC1X bm8tdW51c2VkLWJ1dC1zZXQtdmFyaWFibGUgLVduby11bnVzZWQtbG9jYWwtdHlwZWRlZnMgICAt TzEgLW5vc3RkaW5jIC1mbm8tYnVpbHRpbiAtZm5vLWNvbW1vbiAtV2Vycm9yIC1XcmVkdW5kYW50 LWRlY2xzIC1Xbm8tcG9pbnRlci1hcml0aCAtcGlwZSAtZyAtRF9fWEVOX18gLWluY2x1ZGUgL2hv bWUva29ucmFkL0EyMC94ZW4uZ2l0L3hlbi9pbmNsdWRlL3hlbi9jb25maWcuaCAnLURfX09CSkVD VF9GSUxFX189Inhlbl9ieWVfd29ybGQubyInIC1XYSwtLXN0cmlwLWxvY2FsLWFic29sdXRlIC1m bm8tb21pdC1mcmFtZS1wb2ludGVyIC1NTUQgLU1GIC4vLnhlbl9ieWVfd29ybGQuby5kIC1tc29m dC1mbG9hdCAtbWNwdT1jb3J0ZXgtYTE1IC1JL2hvbWUva29ucmFkL0EyMC94ZW4uZ2l0L3hlbi9p bmNsdWRlIC1mbm8tc3RhY2stcHJvdGVjdG9yIC1mbm8tZXhjZXB0aW9ucyAtV25lc3RlZC1leHRl cm5zIC1ER0NDX0hBU19WSVNJQklMSVRZX0FUVFJJQlVURSAtbWFybSAtREJVSUxEX0lEIC1mbm8t c3RyaWN0LWFsaWFzaW5nIC1zdGQ9Z251OTkgLVdhbGwgLVdzdHJpY3QtcHJvdG90eXBlcyAtV2Rl Y2xhcmF0aW9uLWFmdGVyLXN0YXRlbWVudCAtV25vLXVudXNlZC1idXQtc2V0LXZhcmlhYmxlIC1X bm8tdW51c2VkLWxvY2FsLXR5cGVkZWZzICAgLWMgeGVuX2J5ZV93b3JsZC5jIC1vIHhlbl9ieWVf d29ybGQubwoKCj4gCj4gPiBJZiBJIGNvbXBpbGUgdGhlIHRlc3QtY2FzZSB1bmRlciBBUk0zMiBp dCB3b3JrcyBPSyAoYXMgdGhlCj4gPiAubGl2ZXBhdGNoLmRlcGVuZHMgZW5kcyB1cCBiZWluZyBh bGlnbmVkIHRvIGZvdXIgYnl0ZXMpLgo+IAo+IFNvIHdoeSBpcyB0aGF0PyBXaGF0IGVudGl0eSBp cyBjcmVhdGluZyB0aGlzIHNlY3Rpb24gKG9yIHRoZQo+IGRpcmVjdGl2ZShzKSB0byBjcmVhdGUg aXQpPwoKZ2NjCgpMb29raW5nIGF0IHRoZSB4ZW5fYnllX3dvcmxkLm8gcHJvZHVjZWQgYnkgY3Jv c3MtY29tcGlsZXI6Cgp4ZW5fYnllX3dvcmxkLm86ICAgICBmaWxlIGZvcm1hdCBlbGYzMi1saXR0 bGVhcm0KCkNvbnRlbnRzIG9mIHNlY3Rpb24gLnJvZGF0YToKIDAwMDAgNzg2NTZlNWYgNjU3ODc0 NzIgNjE1Zjc2NjUgNzI3MzY5NmYgIHhlbl9leHRyYV92ZXJzaW8KIDAwMTAgNmUwMCAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIG4uIAoKQW5kIG5hdGl2ZToKCnhlbl9ieWVfd29ybGQu bzogICAgIGZpbGUgZm9ybWF0IGVsZjMyLWxpdHRsZWFybQoKQ29udGVudHMgb2Ygc2VjdGlvbiAu cm9kYXRhOgogMDAwMCA3ODY1NmU1ZiA2NTc4NzQ3MiA2MTVmNzY2NSA3MjczNjk2ZiAgeGVuX2V4 dHJhX3ZlcnNpbwogMDAxMCA2ZTAwMDAwMCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbi4u LiAgICAgIAoKKFRoZSBjcm9zcyBjb21waWxlciBpcyA3LjAuMSwgd2hpbGUgbmF0aXZlIGlzIDQu OS4yKS4KCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpY ZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHBzOi8vbGlz dHMueGVuLm9yZy94ZW4tZGV2ZWwK