From: Greg KH <gregkh@linuxfoundation.org>
To: Georgiana Chelu <georgiana.chelu93@gmail.com>
Cc: outreachy-kernel@googlegroups.com, mchehab@kernel.org
Subject: Re: [PATCH] Staging: media: atomisp: pci: Fix style issues
Date: Tue, 19 Sep 2017 08:10:19 +0200 [thread overview]
Message-ID: <20170919061019.GB1628@kroah.com> (raw)
In-Reply-To: <20170918200649.vpfscgyeuibkvifi@fireworks>
On Mon, Sep 18, 2017 at 11:06:49PM +0300, Georgiana Chelu wrote:
> Improve the coding style by fixing the following warnings/errors:
> * Space prohibited before that ','
> * Missing a blank line after declarations
> * Prefer 'unsigned int' to bare use of 'unsigned'
> * Open brace '{' following function definitions
> go on the next line
> * Comparisons should place the constant on the
> right side of the test
That's a lot of different "things" to be doing all in one patch. I
don't normally accept patches like this, please break it up into "only
do one type of thing" per patch, just like the rest of the patches on
this mailing list.
thanks,
greg k-h
next prev parent reply other threads:[~2017-09-19 6:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-18 20:06 [PATCH] Staging: media: atomisp: pci: Fix style issues Georgiana Chelu
2017-09-19 6:10 ` Greg KH [this message]
2017-09-19 6:29 ` Georgiana Chelu
2017-09-19 6:35 ` Greg KH
2017-09-19 15:43 ` Georgiana Chelu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170919061019.GB1628@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=georgiana.chelu93@gmail.com \
--cc=mchehab@kernel.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.