From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Alan Tull <atull@kernel.org>
Cc: Moritz Fischer <mdf@kernel.org>,
linux-fpga@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] fpga: altera-cvp: remove DRIVER_ATTR() usage
Date: Tue, 19 Sep 2017 09:17:43 +0200 [thread overview]
Message-ID: <20170919071743.GA23085@kroah.com> (raw)
In-Reply-To: <CANk1AXTRoOiqswPi-SzNG01vPRQuAKxsBt3hszyWw7BvPx-YdQ@mail.gmail.com>
On Mon, Sep 18, 2017 at 03:40:13PM -0500, Alan Tull wrote:
> On Mon, Sep 18, 2017 at 11:42 AM, Moritz Fischer <mdf@kernel.org> wrote:
> > On Mon, Sep 18, 2017 at 12:17:36PM +0200, Greg Kroah-Hartman wrote:
> >> It's better to be explicit and use the DRIVER_ATTR_RW() macro when
> >> defining a driver's sysfs file.
> >>
> >> This is part of a series to drop DRIVER_ATTR() from the tree entirely.
> >>
> >> Cc: Alan Tull <atull@kernel.org>
> >> Cc: Moritz Fischer <mdf@kernel.org>
> >> Cc: linux-fpga@vger.kernel.org
> >> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Acked-by: Moritz Fischer <mdf@kernel.org>
> Acked-by: Alan Tull <atull@kernel.org>
Thanks to both of you for the review.
greg k-h
prev parent reply other threads:[~2017-09-19 7:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-18 10:17 [PATCH 1/2] fpga: altera-cvp: remove DRIVER_ATTR() usage Greg Kroah-Hartman
2017-09-18 10:17 ` [PATCH 2/2] driver core: remove DRIVER_ATTR Greg Kroah-Hartman
2017-09-18 16:43 ` Moritz Fischer
2017-09-18 20:42 ` Alan Tull
2017-09-18 16:42 ` [PATCH 1/2] fpga: altera-cvp: remove DRIVER_ATTR() usage Moritz Fischer
2017-09-18 20:40 ` Alan Tull
2017-09-19 7:17 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170919071743.GA23085@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=atull@kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.