From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: Unset legacy_cursor_update early in intel_atomic_commit, v2. Date: Tue, 19 Sep 2017 13:24:11 +0300 Message-ID: <20170919102411.GJ4914@intel.com> References: <20170918101250.6076-1-maarten.lankhorst@linux.intel.com> <20170918150312.GC4914@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2D3B489BA1 for ; Tue, 19 Sep 2017 10:24:19 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBTZXAgMTksIDIwMTcgYXQgMTE6MDY6NTJBTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gT3AgMTgtMDktMTcgb20gMTc6MDMgc2NocmVlZiBWaWxsZSBTeXJqw6Rsw6Q6 Cj4gPiBPbiBNb24sIFNlcCAxOCwgMjAxNyBhdCAxMjoxMjo1MFBNICswMjAwLCBNYWFydGVuIExh bmtob3JzdCB3cm90ZToKPiA+PiBDb21taXQgYjQ0ZDVjMGMxMDVhICgiZHJtL2k5MTU6IEFsd2F5 cyB3YWl0IGZvciBmbGlwX2RvbmUsIHYyLiIpIHJlbW92ZWQKPiA+PiB0aGUgY2FsbCB0byB3YWl0 X2Zvcl92YmxhbmtzIGFuZCByZXBsYWNlZCBpdCB3aXRoIGZsaXBfZG9uZS4KPiA+Pgo+ID4+IFVu Zm9ydHVuYXRlbHkgbGVnYWN5X2N1cnNvcl91cGRhdGUgd2FzIHVuc2V0IHRvbyBsYXRlLCBhbmQg dGhlCj4gPj4gcmVwbGFjZW1lbnQgY2FsbCBkcm1fYXRvbWljX2hlbHBlcl93YWl0X2Zvcl9mbGlw X2RvbmUoKSB3YXMKPiA+PiBhIG5vb3AuIE1ha2Ugc3VyZSB0aGF0IGl0cyB1bnNldCBiZWZvcmUg c2V0dXBfY29tbWl0KCkgaXMKPiA+PiBjYWxsZWQgdG8gZml4IHRoaXMgaXNzdWUuCj4gPj4KPiA+ PiBDaGFuZ2VzIHNpbmNlIHYxOgo+ID4+IC0gRm9yY2UgdmJsYW5rIHdhaXQgZm9yIHdhdGVybWFy a3Mgbm90IHlldCBjb252ZXJ0ZWQgdG8gYXRvbWljIHRvby4gKFZpbGxlKQo+ID4+IC0gVXNlIGZv cl9lYWNoX25ld19pbnRlbF9jcnRjX2luX3N0YXRlLiAoVmlsbGUpCj4gPj4KPiA+PiBTaWduZWQt b2ZmLWJ5OiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwu Y29tPgo+ID4+IEZpeGVzOiBiNDRkNWMwYzEwNWEgKCJkcm0vaTkxNTogQWx3YXlzIHdhaXQgZm9y IGZsaXBfZG9uZSwgdjIuIikKPiA+PiBCdWd6aWxsYTogaHR0cHM6Ly9idWdzLmZyZWVkZXNrdG9w Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyNjc1Cj4gPj4gVGVzdGNhc2U6IGttc19jdXJzb3JfY3Jj Cj4gPj4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4gPj4gQ2M6 IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBsaW51eC5pbnRlbC5jb20+Cj4gPj4gUmVwb3J0ZWQt Ynk6IE1hcnRhIEzDtmZzdGVkdCA8bWFydGEubG9mc3RlZHRAaW50ZWwuY29tPgo+ID4+IENjOiBN YXJ0YSBMw7Zmc3RlZHQgPG1hcnRhLmxvZnN0ZWR0QGludGVsLmNvbT4KPiA+PiBUZXN0ZWQtYnk6 IE1hcnRhIEzDtmZzdGVkdCA8bWFydGEubG9mc3RlZHRAaW50ZWwuY29tPgo+ID4+IENjOiBWaWxs ZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ID4+IC0tLQo+ID4+ ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCA0NSArKysrKysrKysrKysr KysrKysrKystLS0tLS0tLS0tLS0tLS0KPiA+PiAgMSBmaWxlIGNoYW5nZWQsIDI2IGluc2VydGlv bnMoKyksIDE5IGRlbGV0aW9ucygtKQo+ID4+Cj4gPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rp c3BsYXkuYwo+ID4+IGluZGV4IDg1OTllNDI1YWJiMS4uOGQwNTEyNTZkYTFlIDEwMDY0NAo+ID4+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4+IEBAIC0xMjUxNywyMSArMTI1 MTcsMTAgQEAgc3RhdGljIGludCBpbnRlbF9hdG9taWNfY29tbWl0KHN0cnVjdCBkcm1fZGV2aWNl ICpkZXYsCj4gPj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1 KGRldik7Cj4gPj4gIAlpbnQgcmV0ID0gMDsKPiA+PiAgCj4gPj4gLQlyZXQgPSBkcm1fYXRvbWlj X2hlbHBlcl9zZXR1cF9jb21taXQoc3RhdGUsIG5vbmJsb2NrKTsKPiA+PiAtCWlmIChyZXQpCj4g Pj4gLQkJcmV0dXJuIHJldDsKPiA+PiAtCj4gPj4gIAlkcm1fYXRvbWljX3N0YXRlX2dldChzdGF0 ZSk7Cj4gPj4gIAlpOTE1X3N3X2ZlbmNlX2luaXQoJmludGVsX3N0YXRlLT5jb21taXRfcmVhZHks Cj4gPj4gIAkJCSAgIGludGVsX2F0b21pY19jb21taXRfcmVhZHkpOwo+ID4+ICAKPiA+PiAtCXJl dCA9IGludGVsX2F0b21pY19wcmVwYXJlX2NvbW1pdChkZXYsIHN0YXRlKTsKPiA+PiAtCWlmIChy ZXQpIHsKPiA+PiAtCQlEUk1fREVCVUdfQVRPTUlDKCJQcmVwYXJpbmcgc3RhdGUgZmFpbGVkIHdp dGggJWlcbiIsIHJldCk7Cj4gPj4gLQkJaTkxNV9zd19mZW5jZV9jb21taXQoJmludGVsX3N0YXRl LT5jb21taXRfcmVhZHkpOwo+ID4+IC0JCXJldHVybiByZXQ7Cj4gPj4gLQl9Cj4gPj4gLQo+ID4+ ICAJLyoKPiA+PiAgCSAqIFRoZSBpbnRlbF9sZWdhY3lfY3Vyc29yX3VwZGF0ZSgpIGZhc3QgcGF0 aCB0YWtlcyBjYXJlCj4gPj4gIAkgKiBvZiBhdm9pZGluZyB0aGUgdmJsYW5rIHdhaXRzIGZvciBz aW1wbGUgY3Vyc29yCj4gPj4gQEAgLTEyNTQwLDE5ICsxMjUyOSwzNyBAQCBzdGF0aWMgaW50IGlu dGVsX2F0b21pY19jb21taXQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiA+PiAgCSAqIHVwZGF0 ZXMgaGFwcGVuIGR1cmluZyB0aGUgY29ycmVjdCBmcmFtZXMuIEdlbjkrIGhhdmUKPiA+PiAgCSAq IGRvdWJsZSBidWZmZXJlZCB3YXRlcm1hcmtzIGFuZCBzbyBzaG91bGRuJ3QgbmVlZCB0aGlzLgo+ ID4+ICAJICoKPiA+PiAtCSAqIERvIHRoaXMgYWZ0ZXIgZHJtX2F0b21pY19oZWxwZXJfc2V0dXBf Y29tbWl0KCkgYW5kCj4gPj4gLQkgKiBpbnRlbF9hdG9taWNfcHJlcGFyZV9jb21taXQoKSBiZWNh dXNlIHdlIHN0aWxsIHdhbnQKPiA+PiAtCSAqIHRvIHNraXAgdGhlIGZsaXAgYW5kIGZiIGNsZWFu dXAgd2FpdHMuIEFsdGhvdWdoIHRoYXQKPiA+PiAtCSAqIGRvZXMgcmlzayB5YW5raW5nIHRoZSBt YXBwaW5nIGZyb20gdW5kZXIgdGhlIGRpc3BsYXkKPiA+PiAtCSAqIGVuZ2luZS4KPiA+PiArCSAq IFVuc2V0IHN0YXRlLT5sZWdhY3lfY3Vyc29yX3VwZGF0ZSBiZWZvcmUgdGhlIGNhbGwgdG8KPiA+ PiArCSAqIGRybV9hdG9taWNfaGVscGVyX3NldHVwX2NvbW1pdCgpIGJlY2F1c2Ugb3RoZXJ3aXNl Cj4gPj4gKwkgKiBkcm1fYXRvbWljX2hlbHBlcl93YWl0X2Zvcl9mbGlwX2RvbmUoKSBpcyBhIG5v b3AgYW5kCj4gPj4gKwkgKiB3ZSBnZXQgRklGTyB1bmRlcnJ1bnMgYmVjYXVzZSB3ZSBkaWRuJ3Qg d2FpdAo+ID4+ICsJICogZm9yIHZibGFuay4KPiA+PiAgCSAqCj4gPj4gIAkgKiBGSVhNRSBkb2lu ZyB3YXRlcm1hcmtzIGFuZCBmYiBjbGVhbnVwIGZyb20gYSB2Ymxhbmsgd29ya2VyCj4gPj4gIAkg KiAoYXNzdW1pbmcgd2UgaGFkIGFueSkgd291bGQgc29sdmUgdGhlc2UgcHJvYmxlbXMuCj4gPj4g IAkgKi8KPiA+PiAtCWlmIChJTlRFTF9HRU4oZGV2X3ByaXYpIDwgOSkKPiA+PiAtCQlzdGF0ZS0+ bGVnYWN5X2N1cnNvcl91cGRhdGUgPSBmYWxzZTsKPiA+PiArCWlmIChJTlRFTF9HRU4oZGV2X3By aXYpIDwgOSAmJiBzdGF0ZS0+bGVnYWN5X2N1cnNvcl91cGRhdGUpIHsKPiA+PiArCQlzdHJ1Y3Qg aW50ZWxfY3J0Y19zdGF0ZSAqbmV3X2NydGNfc3RhdGU7Cj4gPj4gKwkJc3RydWN0IGludGVsX2Ny dGMgKmNydGM7Cj4gPj4gKwkJaW50IGk7Cj4gPj4gKwo+ID4+ICsJCWZvcl9lYWNoX25ld19pbnRl bF9jcnRjX2luX3N0YXRlKGludGVsX3N0YXRlLCBjcnRjLCBuZXdfY3J0Y19zdGF0ZSwgaSkKPiA+ PiArCQkJaWYgKG5ld19jcnRjX3N0YXRlLT53bS5uZWVkX3Bvc3R2YmxfdXBkYXRlIHx8Cj4gPj4g KwkJCSAgICBuZXdfY3J0Y19zdGF0ZS0+dXBkYXRlX3dtX3Bvc3QpCj4gPj4gKwkJCQlzdGF0ZS0+ bGVnYWN5X2N1cnNvcl91cGRhdGUgPSBmYWxzZTsKPiA+IEhtbS4gSSBndWVzcyB0aGF0J3MgYmV0 dGVyLiBCdXQgSSBzdGlsbCBkb24ndCBzZWUgd2h5IHlvdSB3YW50IHRvIGNoYW5nZQo+ID4gdGhp cyBiaXQgb2YgY29kZSBpbiB0aGlzIHBhdGNoLiBBRkFJQ1MgaXQncyBnb3Qgbm90aGluZyB0byBk byB3aXRoIHRoZSBmaXgKPiA+IGl0c2VsZiwgYW5kIGluc3RlYWQgaXQncyBqdXN0IHRyeWluZyB0 byBvcHRpbWl6ZSBzb21lIGN1cnNvciB1cGRhdGVzCj4gPiB0aGF0IHdlcmUga2lja2VkIG92ZXIg dG8gdGhlIHNsb3cgcGF0aC4gT3IgYW0gSSBtaXNzaW5nIHNvbWV0aGluZz8KPiAKPiBXZSBhY2Np ZGVudGFsbHkgcmVtb3ZlZCB0aGUgdmJsYW5rIHdhaXQgZm9yIHRoZSBzbG93cGF0aCwgYnV0IEkg ZG9uJ3QgdGhpbmsgd2Ugc2hvdWxkIHJlaW50cm9kdWNlIHRoZSB2YmxhbmsgZXhjZXB0IHdoZXJl IHdlIG5lZWQgaXQuLgoKSU1PIGFueSByZWdyZXNzaW9uIGZpeCBzaG91bGQgaWRlYWxseSBnZXQg dXMgYmFjayBleGFjdGx5IHdoZXJlIHdlIHdlcmUuCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVs IE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRl bC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK