Re: [PATCH] bdi: fix cleanup when fail to percpu_counter_init

[weiping zhang <zhangweiping@didichuxing.com>]

On Tue, Sep 19, 2017 at 10:13:31AM +0200, Jan Kara wrote:
> On Mon 18-09-17 08:04:04, Jens Axboe wrote:
> > On 09/15/2017 12:27 PM, weiping zhang wrote:
> > > when percpu_counter_init fail at i, 0 ~ (i-1) should be destoried, not
> > > 1 ~ i.
> > > 
> > > Signed-off-by: weiping zhang <zhangweiping@didichuxing.com>
> > > ---
> > >  mm/backing-dev.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/mm/backing-dev.c b/mm/backing-dev.c
> > > index e19606b..d399d3c 100644
> > > --- a/mm/backing-dev.c
> > > +++ b/mm/backing-dev.c
> > > @@ -334,7 +334,7 @@ static int wb_init(struct bdi_writeback *wb, struct backing_dev_info *bdi,
> > >  	return 0;
> > >  
> > >  out_destroy_stat:
> > > -	while (i--)
> > > +	while (--i >= 0)
> > 
> > These two constructs will produce identical results.
> 
> Bah, you are correct. I got confused.
> 

It's my fault, thanks all of you, ^_^

weiping

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>