From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anatolij Gustschin Date: Tue, 19 Sep 2017 14:18:56 +0200 Subject: [U-Boot] [PATCH] imx6: disable clock command and print_cpuinfo code in SPL In-Reply-To: <58344258-849d-2eb0-39f4-444178f2953e@denx.de> References: <1503949586-24936-1-git-send-email-agust@denx.de> <58344258-849d-2eb0-39f4-444178f2953e@denx.de> Message-ID: <20170919141856.12fb051a@crub> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Stefano, On Tue, 19 Sep 2017 09:54:30 +0200 Stefano Babic sbabic at denx.de wrote: ... > This patch has some side-effects and breaks some boards. Even if the > changes are correct, some boards (wandboard, icore are examples) don't > disable IPU support in SPL. Even if this is useless and generates only a > bigger footprint. > > In fact, I get : > > arm: + wandboard > +board/wandboard/built-in.o: In function `setup_display': > +board/wandboard/wandboard.c:355: undefined reference to `enable_ipu_clock' > +make[2]: *** [spl/u-boot-spl] Error 1 > +make[1]: *** [spl/u-boot-spl] Error 2 > +make: *** [sub-make] Error 2 > > > Reason is clear: boards have in SPL a setup_display() that calls > enable_ipu_clock. But it makes no sense to have IPU support in SPL. > > We can fix with a follow-up patch, but this is bad for bisecting. The > other option is to fix here and disable IPU in spl for the affected > boards. What you think ? Sorry for the build breakage, I didn't test with a full imx6 build. Yes, we shouldn't break bisection. I'll fix and resubmit. Thanks! -- Anatolij