From: Al Viro <viro@ZenIV.linux.org.uk>
To: Will Deacon <will.deacon@arm.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] ipc/shm: Fix order of parameters when calling copy_compat_shmid_to_user
Date: Wed, 20 Sep 2017 12:01:07 +0100 [thread overview]
Message-ID: <20170920110107.GC32076@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1505753258-19470-1-git-send-email-will.deacon@arm.com>
On Mon, Sep 18, 2017 at 05:47:38PM +0100, Will Deacon wrote:
> Commit 553f770ef71b ("ipc: move compat shmctl to native") moved the
> compat IPC syscall handling into ipc/shm.c and refactored the struct
> accessors in the process. Unfortunately, the call to
> copy_compat_shmid_to_user when handling a compat {IPC,SHM}_STAT command
> gets the arguments the wrong way round, passing a kernel stack address
> as the user buffer (destination) and the user buffer as the kernel stack
> address (source).
>
> This patch fixes the parameter ordering so the buffers are accessed
> correctly.
ACK, will push to Linus tonight...
prev parent reply other threads:[~2017-09-20 11:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-18 16:47 [PATCH] ipc/shm: Fix order of parameters when calling copy_compat_shmid_to_user Will Deacon
2017-09-20 9:41 ` Will Deacon
2017-09-20 11:01 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170920110107.GC32076@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.