Re: [Outreachy kernel] [PATCH 0/3] GPU: DRM: drm_agpsupport.c: Code cleanup

[Daniel Vetter <daniel@ffwll.ch>]

On Mon, Sep 18, 2017 at 11:05:39PM +0000, Vetter, Daniel wrote:
> On Wed, 2017-09-13 at 15:58 +0300, Jani Nikula wrote:
> > On Wed, 13 Sep 2017, Julia Lawall <julia.lawall@lip6.fr> wrote:
> > > On Wed, 13 Sep 2017, Meghana Madhyastha wrote:
> > > 
> > > > These patches fix the checkpath warnings and errors
> > > > in drm_agpsupport.c
> > > > 
> > > > Meghana Madhyastha (3):
> > > > � GPU: DRM: Moved EXPORT_SYMBOL so that it immediately followed
> > > > its
> > > > ����function
> > > > � GPU: DRM: Replace "foo * bar" with "foo *bar"
> > > > � GPU: DRM: Remove assignment in if condition
> > > > 
> > > > �drivers/gpu/drm/drm_agpsupport.c | 41 ++++++++++++++++++++++--
> > > > ----------------
> > 
> > Please try 'git log --oneline -- drivers/gpu/drm/drm_agpsupport.c'
> > and
> > observe the commit subject prefix used. Please try to follow the
> > style
> > in the area you're changing, not some generic rules.
> > 
> > > > �1 file changed, 23 insertions(+), 18 deletions(-)
> > > 
> > > Are the DRM people going to pick this up?��Because Greg will
> > > not.��If you
> > > do something that is outside staging at a mentor's suggestion it
> > > could be
> > > good to make explicit that the mentor will make sure that the patch
> > > will
> > > be applied.
> > 
> > I'm not generally fond of pure checkpatch fixes, but patch 3 alone I
> > want enough to pick them all up. ;)
> > 
> > But please do submit the series to dri-devel@lists.freedesktop.org.
> > As a
> > matter of policy, we don't apply patches not posted to our subsystem
> > mailing list.
> 
> Yeah, stuff needs to go through dri-devel when it's a drm patch (or
> anything else in drivers/gpu). That's why we don't recommend it for the
> very first patch (I guess I should update the text a bit, but I'm
> travelling and don't have login creds nearby).

Hm, not all of these landed. Haneen, can you pls resend the remaining
patches with dri-devel (and maintainers, per scripts/get_maintainer.pl) on
cc?

Thanks, Daniel


> -Daniel
> 
> > The scripts/get_maintainer.pl script will help you with the lists,
> > but
> > do use discretion. The script is sometimes misguided, adding *way*
> > too
> > many lists and people. Just the main subsystem list and
> > supporters/maintainers are usually enough.
> > 
> > 
> > Thanks,
> > Jani.
> > 
> > 
> Intel Semiconductor AG
> Registered No. 020.30.913.786-7
> Registered Office: Badenerstrasse 549, 8048 Zurich, Switzerland
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1505775934.6581.6.camel%40intel.com.
> For more options, visit https://groups.google.com/d/optout.

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch