From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751985AbdITUzz (ORCPT <rfc822;w@1wt.eu>);
        Wed, 20 Sep 2017 16:55:55 -0400
Received: from mail.windriver.com ([147.11.1.11]:46965 "EHLO
        mail.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750872AbdITUzy (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 20 Sep 2017 16:55:54 -0400
Date: Wed, 20 Sep 2017 16:55:19 -0400
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
CC: Andrew Morton <akpm@linux-foundation.org>,
        Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] init/version: include <linux/export.h> instead of
 <linux/module.h>
Message-ID: <20170920205519.GM3007@windriver.com>
References: <1505920984-8523-1-git-send-email-yamada.masahiro@socionext.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <1505920984-8523-1-git-send-email-yamada.masahiro@socionext.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

[[PATCH] init/version: include <linux/export.h> instead of <linux/module.h>] On 21/09/2017 (Thu 00:23) Masahiro Yamada wrote:

> init/version.c has nothing to do with module, so remove
> the <linux/modude.h>.
> 
> Instead, include <linux/export.h> for EXPORT_SYMBOL_GPL.

I checked and there weren't any __init lurking in that file which is the
usual other required replacement (<linux/init.h>) so this should be
fine.

Paul.
--

> 
> This cuts off a lot of unnecessary header parsing.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
> 
>  init/version.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/init/version.c b/init/version.c
> index 5606341..bfb4e3f 100644
> --- a/init/version.c
> +++ b/init/version.c
> @@ -7,7 +7,7 @@
>   */
>  
>  #include <generated/compile.h>
> -#include <linux/module.h>
> +#include <linux/export.h>
>  #include <linux/uts.h>
>  #include <linux/utsname.h>
>  #include <generated/utsrelease.h>
> -- 
> 2.7.4
>